----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12074/#review22345 -----------------------------------------------------------
Ship it! src/slave/reaper.cpp <https://reviews.apache.org/r/12074/#comment45846> Maybe something simpler (so as not to conflate an error for something doesn't exist, i.e., the 'isNone()' check below): LOG(ERROR) << "Failed to get process information for " << pid; src/slave/reaper.cpp <https://reviews.apache.org/r/12074/#comment45845> Maybe just say something along the lines of "process appears to have been reaped (i.e., no longer exists)"? - Benjamin Hindman On June 25, 2013, 4:46 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12074/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 4:46 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: mesos-520 > https://issues.apache.org/jira/browse/mesos-520 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.cpp 5d63bde54b458e2067b9119383b3fe042c1874de > src/slave/process_isolator.cpp b750b26e73a69f0db3cac3e648dc0a77da1f1812 > src/slave/reaper.hpp 2d6db03760c25550317e79fea837f04e56fed617 > src/slave/reaper.cpp 8d3101df7a2ca1a0ab90a13dd828c072fae441ce > src/tests/reaper_tests.cpp d55ac24f323c66ab8098072d923ec528bf4bf11d > > Diff: https://reviews.apache.org/r/12074/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="ReaperTest.*" --gtest_repeat=1000 > --gtest_break_on_failure > > > Thanks, > > Jiang Yan Xu > >
