> On June 25, 2013, 6:22 a.m., Ben Mahler wrote: > > src/slave/reaper.cpp, lines 50-57 > > <https://reviews.apache.org/r/12074/diff/1/?file=310716#file310716line50> > > > > Do these "permissions" comments still reflect the code? I thought these > > were because of the kill() semantics?
I am mainly concerned that on OSX whether there are situations where a valid pid cannot be detected by sysctl due to permissions. From previous conversation with BenM seems like there were such reported cases but it didn't happen in our tests. It's OK if the fields in os::Process aren't all accurately populated. So if there is no need to worry about this I can kill the comments and the `waitpid` call in ReaperProcess:monitor altogether. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12074/#review22348 ----------------------------------------------------------- On June 25, 2013, 4:46 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12074/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 4:46 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: mesos-520 > https://issues.apache.org/jira/browse/mesos-520 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.cpp 5d63bde54b458e2067b9119383b3fe042c1874de > src/slave/process_isolator.cpp b750b26e73a69f0db3cac3e648dc0a77da1f1812 > src/slave/reaper.hpp 2d6db03760c25550317e79fea837f04e56fed617 > src/slave/reaper.cpp 8d3101df7a2ca1a0ab90a13dd828c072fae441ce > src/tests/reaper_tests.cpp d55ac24f323c66ab8098072d923ec528bf4bf11d > > Diff: https://reviews.apache.org/r/12074/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="ReaperTest.*" --gtest_repeat=1000 > --gtest_break_on_failure > > > Thanks, > > Jiang Yan Xu > >
