> On June 20, 2013, 11:40 p.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 785 > > <https://reviews.apache.org/r/11124/diff/5/?file=303778#file303778line785> > > > > Can you instead do MesosTracker.this.active instead of storing the > > parent?
I didn't know you could do that, thanks! > On June 20, 2013, 11:40 p.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lines > > 766-772 > > <https://reviews.apache.org/r/11124/diff/5/?file=303778#file303778line766> > > > > I think we'll need to add the 'volatile' keyword for any of these that > > are accessed by the timer, right? My Java is a bit rusty. You're right. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11124/#review22210 ----------------------------------------------------------- On June 11, 2013, 8 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11124/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 8 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Kill tasks that never properly launch. > > After trying to launch a task tracker, we'll wait up to 5 minutes before > giving up and killing the task. > > Review: https://reviews.apache.org/r/11124 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > afe401f5265e3d9494af7eace42eec45943184a3 > > Diff: https://reviews.apache.org/r/11124/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
