----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11124/#review22516 -----------------------------------------------------------
This is looking good to me! hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11124/#comment46184> s/up/up./ hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11124/#comment46185> Can you call killTracker() instead here? Looks like killTracker() should do a cancel? hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11124/#comment46186> @Override? - Ben Mahler On June 26, 2013, 9:17 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11124/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 9:17 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Kill tasks that never properly launch. > > After trying to launch a task tracker, we'll wait up to 5 minutes before > giving up and killing the task. > > Review: https://reviews.apache.org/r/11124 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > c5a63bc7a172c44cc11d6bdd6b2eb4bc3df35cb7 > > Diff: https://reviews.apache.org/r/11124/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
