Hi Denys, Thanks to you and Franklin for giving me these pointers. I will take care of these recommendations for the next patches.
Checked the dora branch this morning and see that you have merged the patches probably from the v1 of the patch set. I have a few more patches with respect to the connectivity, will send them out today. Regards Karthik -----Original Message----- From: Dmytriyenko, Denys Sent: Wednesday, September 03, 2014 11:42 PM To: R, Karthik Cc: Cooper Jr., Franklin; [email protected] Subject: Re: [meta-arago] [PATCH 00/12] Enabling WL8 R8.4 on dora On Wed, Sep 03, 2014 at 12:46:11PM +0000, R, Karthik wrote: > Hi Franklin, > > Thanks for your inputs. I did some reading about these suggestions and > I fully understand your intent behind it. > I have regenerated the patches sent out the version 2 of this patch > set for review. Please review them if you find it in order. > If you need more details about the patches do let me know. > > I read a note in the git help that said that the patches generated by > using the options that make the differences minimal like the -D option > will result in patches that cannot be applied by git am. > So from a review point its fine, but I don't understand how it will > get merged into the repo? > Could you please help me understand the flow of the patches? Karthik, So, the recommendation is to use options -C, -M and --find-copies-harder (the last one applies to either -C or -M, if you don't want to specify their values directly) Please don't use -D option as it does indeed make patches un-applicable. E.g. your second set cannot be applies as is now. It may make patches with whole file being deleted smaller and easier to review though, but whole-file deletions are easy to see and skip anyway, so the small benefit doesn't outweigh the pain of not being able to apply the patch. The workflow I use is to review the patches on the list (prefer -C and -M to be used) and let our internal Patchwork capture everything. Then I apply the accepted patches directly from Patchwork the way they were submitted and Acked and push them in sets of small batches. The review process is usually given a few days on the list, unless the patch is critical and has to be pushed ASAP. -- Denys > -----Original Message----- > From: Cooper Jr., Franklin > Sent: Wednesday, September 03, 2014 3:17 AM > To: R, Karthik; [email protected] > Subject: RE: [meta-arago] [PATCH 00/12] Enabling WL8 R8.4 on dora > > If you can resend using --find-copies-harder it will make it a lot easier to > review. You might also need to play with the -M option to make sure your > only sending as little deltas as possible. > > Also it would be nice in each of the patches if you add [for dora] to the > patch subject. I know you indicated that in the cover letter but it just > makes things easier and a good habit in case you don't always send cover > letters. > > I always use git send-email --annotate and manually add things like that to > each patch before I send it. A bit of a hassle for the sender but makes the > reviewer's life easier :) > > > -----Original Message----- > > From: [email protected] [mailto:meta-arago- > > [email protected]] On Behalf Of R, Karthik > > Sent: Tuesday, September 02, 2014 5:55 AM > > To: [email protected] > > Subject: [meta-arago] [PATCH 00/12] Enabling WL8 R8.4 on dora > > > > This patch set contains the set of patches that are required to get > > the latest Wilink firmware on the dora branch. > > Most of the patches here are cherry picked from the master branch. A > > few of them needed minor rework. > > > > Note that this has been tested on the GLSDK 6.10 release line for > > dra7xx-evm as the target. > > > > Denys Dmytriyenko (4): > > wl18xx-firmware: specify the branch being used for this version > > hostap-daemon: specify the branch being used for this version > > wpa-supplicant: specify the branch being used for this version > > recipes-connectivity: remove remaining unnecessary exec permissions > > > > Yaniv Machani (8): > > wpa-supplicant-wl18xx: Update recipe to ol_r8.a9.14 version. > > hostap-daemon-wl18xx: Update recipe to ol_r8.a9.14 version > > wl18xx : update to ol_r8.a9.14 > > Wl18xx : recipes update - tag changed to ol_r8.a9.14 > > wl18xx-target-scripts : Add new WiFi related scripts > > wl18xx-compat: version update > > wl18xx-wlconf: version update > > wpa-supplicant-wl18xx: configuration files update > > > > ...synchronization-between-bluetoothd-and-dr.patch | 0 > > .../0001-obexd-make-OPP-push-timeout-longer.patch | 0 > > .../packagegroup-arago-tisdk-connectivity.bb | 4 +- > > .../ti-compat-wireless-wl18xx_r8.a8.10.bb | 61 --- > > .../ti-compat-wireless-wl18xx_r8.a9.14.bb | 51 ++ > > .../wl18xx-firmware/wl18xx-firmware_r8.a8.10.bb | 30 -- > > .../wl18xx-firmware/wl18xx-firmware_r8.a9.14.bb | 31 ++ > > .../hostap/hostap-daemon-wl18xx_r8.a8.10.bb | 23 - > > .../hostap/hostap-daemon-wl18xx_r8.a9.14.bb | 24 + > > .../hostap/hostap-daemon/defconfig | 2 +- > > .../recipes-connectivity/hostap/hostap.inc | 7 +- > > .../wl18xx-target-scripts_r8.a9.14.bb | 25 + > > .../recipes-connectivity/wlconf/wlconf_r8.a8.10.bb | 41 -- > > .../recipes- connectivity/wlconf/wlconf_r8.a9.14.bb | 42 ++ > > .../wpa-supplicant/wpa- supplicant-wl18xx/defconfig | 506 > > ------------------- > > .../wpa-supplicant-wl18xx_r8.a8.10.bb | 24 - > > .../wpa-supplicant-wl18xx_r8.a9.14.bb | 25 + > > .../wpa-supplicant/wpa-supplicant.inc | 91 ++-- > > .../wpa-supplicant/wpa-supplicant/defaults-sane | 8 - > > .../wpa-supplicant/wpa-supplicant/defconfig | 543 > > +++++++++++++++++++++ > > .../fi.epitest.hostap.WPASupplicant.service | 4 - > > .../wpa-supplicant/fi.w1.wpa_supplicant1.service | 4 - > > .../wpa-supplicant/p2p_supplicant.conf | 3 +- > > .../wpa-supplicant/wpa_supplicant.conf | 3 +- > > .../ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a8.10.bb | 31 -- > > .../ti-wifi-utils/ti-wifi- utils-wl18xx_r8.a9.14.bb | 31 ++ > > 26 files changed, 814 insertions(+), 800 deletions(-) mode change > > 100755 => > > 100644 meta-arago-distro/recipes-connectivity/bluez/bluez4/bluez4-fix- > > synchronization-between-bluetoothd-and-dr.patch > > mode change 100755 => 100644 meta-arago-distro/recipes- > > connectivity/obexd/obexd-0.34/0001-obexd-make-OPP-push-timeout- > > longer.patch > > mode change 100644 => 100755 meta-arago-distro/recipes- > > core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > > delete mode 100644 > > meta-arago-extras/recipes-bsp/ti-compat-wireless/ti- > > compat-wireless-wl18xx_r8.a8.10.bb > > create mode 100644 > > meta-arago-extras/recipes-bsp/ti-compat-wireless/ti- > > compat-wireless-wl18xx_r8.a9.14.bb > > delete mode 100644 meta-arago-extras/recipes-bsp/wl18xx- > > firmware/wl18xx-firmware_r8.a8.10.bb > > create mode 100644 meta-arago-extras/recipes-bsp/wl18xx- > > firmware/wl18xx-firmware_r8.a9.14.bb > > delete mode 100644 meta-arago-extras/recipes- > > connectivity/hostap/hostap-daemon-wl18xx_r8.a8.10.bb > > create mode 100644 meta-arago-extras/recipes- > > connectivity/hostap/hostap-daemon-wl18xx_r8.a9.14.bb > > create mode 100644 meta-arago-extras/recipes-connectivity/wl18xx- > > target-scripts/wl18xx-target-scripts_r8.a9.14.bb > > delete mode 100644 meta-arago-extras/recipes- > > connectivity/wlconf/wlconf_r8.a8.10.bb > > create mode 100644 meta-arago-extras/recipes- > > connectivity/wlconf/wlconf_r8.a9.14.bb > > delete mode 100755 meta-arago-extras/recipes-connectivity/wpa- > > supplicant/wpa-supplicant-wl18xx/defconfig > > delete mode 100644 meta-arago-extras/recipes-connectivity/wpa- > > supplicant/wpa-supplicant-wl18xx_r8.a8.10.bb > > create mode 100644 meta-arago-extras/recipes-connectivity/wpa- > > supplicant/wpa-supplicant-wl18xx_r8.a9.14.bb > > delete mode 100644 meta-arago-extras/recipes-connectivity/wpa- > > supplicant/wpa-supplicant/defaults-sane > > create mode 100755 meta-arago-extras/recipes-connectivity/wpa- > > supplicant/wpa-supplicant/defconfig > > delete mode 100644 meta-arago-extras/recipes-connectivity/wpa- > > supplicant/wpa-supplicant/fi.epitest.hostap.WPASupplicant.service > > delete mode 100644 meta-arago-extras/recipes-connectivity/wpa- > > supplicant/wpa-supplicant/fi.w1.wpa_supplicant1.service > > delete mode 100644 > > meta-arago-extras/recipes-devtools/ti-wifi-utils/ti- > > wifi-utils-wl18xx_r8.a8.10.bb > > create mode 100644 > > meta-arago-extras/recipes-devtools/ti-wifi-utils/ti- > > wifi-utils-wl18xx_r8.a9.14.bb > > > > -- > > 2.0.1 > > > > _______________________________________________ > > meta-arago mailing list > > [email protected] > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > [email protected] > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
