On Fri, Jan 20 2023 at 01:26:36 PM -0500, Denys Dmytriyenko
<[email protected]> wrote:
E.g. if you are copying the entire Mesa set of recipes, include files
and
patches, it should have been a separate patch with just that w/o any
modifications, clearly stating that this is a verbatim copy and
specify which
repo and branch/tag they are being picked up from - openembedded-core
repo,
kirkstone branch.
But then I would argue that a simple mesa_%.bbappend is smaller and
much
easire to review. For example, I took your previous v4 revision of
the patch
and dropped all copies of upstream Mesa, replacing it with a bbappend:
https://patchwork.yoctoproject.org/project/ti/patch/[email protected]/
Right, sorry about that. You are correct that the duplication of mesa
and mesa patches should have occurred in a separate patch, however it
should not be a blanket BB appends. The reason this duplication exists
is that upstream mesa will move faster than our modified versions (as
much as I would like to avoid it) and this will prevent things from
silently creeping forward and breaking. The umlibs are still dependent
on particular, patched releases of mesa.
On Fri, Jan 20 2023 at 01:26:36 PM -0500, Denys Dmytriyenko
<[email protected]> wrote:
I looked at this repo - it's a personal copy of upstream Mesa with
Imagination
PVR patches applied on top. Was it reviewed and approved by OSRB?
Were the
patches made public before and/or permitted to be
published/distributed?
Those patches inherited the license of mesa and therefore did not need
approval from OSRB. I did, however, get IMG's grace to release them
anyway. The reason why it's a personal repo is there is certain
functionality that I believe can be upstreamed and I believe hosting
that process on freedesktop will help reduce friction and be a little
more transparent about our efforts.
On Fri, Jan 20 2023 at 01:26:36 PM -0500, Denys Dmytriyenko
<[email protected]> wrote:
Only rogue?
Only rogue. I added all the necessary hooks for sgx but it still needs
work before it can fall in line with my changes. The mesa layer needs
some TLC and the umlibs will need some packaging changes. Thankfully
SGX can now be disabled until we have it working by removing
powervr-sgx-graphics from the distro features string.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15613):
https://lists.yoctoproject.org/g/meta-ti/message/15613
Mute This Topic: https://lists.yoctoproject.org/mt/96386295/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
