On 6/14/2024 10:08 PM, Denys Dmytriyenko wrote:
On Fri, Jun 14, 2024 at 03:50:14PM +0530, Aniket Limaye via 
lists.yoctoproject.org wrote:
Hi Denys,

On 6/13/2024 10:52 PM, Denys Dmytriyenko wrote:
From: Denys Dmytriyenko<denys@ konsulko. com>  Adjust
IMAGE_BOOT_FILES list as some BSPs do not support all combinations
of SR1. 1, SR2. 0, HS-FS and HS-SE variants. Signed-off-by: Denys
Dmytriyenko<denys@ konsulko. com>  ---
meta-ti-bsp/conf/machine/include/j721e. inc
ZjQcmQRYFpfptBannerStart
From: Denys Dmytriyenko<[email protected]>
Adjust IMAGE_BOOT_FILES list as some BSPs do not support all combinations
of SR1.1, SR2.0, HS-FS and HS-SE variants.

Signed-off-by: Denys Dmytriyenko<[email protected]>
---
Same change is needed for J7200 as well. At the current commit
pointed by u-boot-ti-mainline [1], j7200 only has support for below:
GP , SR2.0 HS-FS , SR2.0 HS-SE

Hence also suggest below for j7200.inc:

diff --git a/meta-ti-bsp/conf/machine/include/j7200.inc
b/meta-ti-bsp/conf/machine/include/j7200.inc
index caa79876..2a11e3dd 100644
--- a/meta-ti-bsp/conf/machine/include/j7200.inc
+++ b/meta-ti-bsp/conf/machine/include/j7200.inc
@@ -5,10 +5,14 @@ SOC_FAMILY:append = ":j7200"
  IMAGE_BOOT_FILES += "tiboot3-j7200-gp-evm.bin"

  # Since default tiboot3.bin on J7200 is for GP, add a version for
SR1.0 HS-FS
-IMAGE_BOOT_FILES += "tiboot3-j7200-hs-fs-evm.bin"
+IMAGE_SR1_HS_FS_FILES = "tiboot3-j7200-hs-fs-evm.bin"
+IMAGE_SR1_HS_FS_FILES:bsp-mainline = ""
+IMAGE_BOOT_FILES += "${IMAGE_SR1_HS_FS_FILES}"

  # Since default tiboot3.bin on J7200 is for GP, add a version for
SR1.0 HS-SE
-IMAGE_BOOT_FILES += "tiboot3-j7200-hs-evm.bin"
+IMAGE_SR1_HS_SE_FILES = "tiboot3-j7200-hs-evm.bin"
+IMAGE_SR1_HS_SE_FILES:bsp-mainline = ""
+IMAGE_BOOT_FILES += "${IMAGE_SR1_HS_SE_FILES}"

  # Since default tiboot3.bin on J7200 is for GP, add a version for
SR2.0 HS-FS
  IMAGE_BOOT_FILES += "tiboot3-j7200_sr2-hs-fs-evm.bin"


[1]:https://source.denx.de/u-boot/u-boot/-/blob/866ca972d6c3cabeaf6dbac431e8e08bb30b3c8e/arch/arm/dts/k3-j7200-binman.dtsi
Thanks! Patches are welcome.

It wasn't possible for me to test all platforms for all 4 supported "BSPs" - I
only focused on all Beagles and few EVMs, so some could have been missed,
especially for the "mainline" BSP.

Denys,

Yeah that makes sense... was only wondering if you'd want to send the patch in the same series... I see your v2 though... will send patches for other platforms for Jacinto based on that.

Btw, I forgot to mention earlier but I like the rework being done in the patch!

Thanks,
Aniket



  meta-ti-bsp/conf/machine/include/j721e.inc | 18 ++++++++++--------
  1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/meta-ti-bsp/conf/machine/include/j721e.inc 
b/meta-ti-bsp/conf/machine/include/j721e.inc
index a54c3f2f..62487aa9 100644
--- a/meta-ti-bsp/conf/machine/include/j721e.inc
+++ b/meta-ti-bsp/conf/machine/include/j721e.inc
@@ -13,20 +13,22 @@ IMAGE_BOOT_FILES += "tiboot3-j721e-gp-evm.bin"
  IMAGE_BOOT_FILES += "sysfw-j721e-gp-evm.itb"
  # Since default on J721e is for GP, add a version for SR1.1 HS-FS
-IMAGE_BOOT_FILES += "tiboot3-j721e_sr1_1-hs-fs-evm.bin"
-IMAGE_BOOT_FILES += "sysfw-j721e_sr1_1-hs-fs-evm.itb"
+IMAGE_SR1_1_HS_FS_FILES = "tiboot3-j721e_sr1_1-hs-fs-evm.bin 
sysfw-j721e_sr1_1-hs-fs-evm.itb"
+IMAGE_SR1_1_HS_FS_FILES:bsp-mainline = ""
+IMAGE_BOOT_FILES += "${IMAGE_SR1_1_HS_FS_FILES}"
  # Since default on J721e is for GP, add a version for SR1.1 HS-SE
-IMAGE_BOOT_FILES += "tiboot3-j721e_sr1_1-hs-evm.bin"
-IMAGE_BOOT_FILES += "sysfw-j721e_sr1_1-hs-evm.itb"
+IMAGE_SR1_1_HS_SE_FILES = "tiboot3-j721e_sr1_1-hs-evm.bin 
sysfw-j721e_sr1_1-hs-evm.itb"
+IMAGE_BOOT_FILES += "${IMAGE_SR1_1_HS_SE_FILES}"
  # Since default on J721e is for GP, add a version for SR2.0 HS-FS
-IMAGE_BOOT_FILES += "tiboot3-j721e_sr2-hs-fs-evm.bin"
-IMAGE_BOOT_FILES += "sysfw-j721e_sr2-hs-fs-evm.itb"
+IMAGE_SR2_HS_FS_FILES = "tiboot3-j721e_sr2-hs-fs-evm.bin 
sysfw-j721e_sr2-hs-fs-evm.itb"
+IMAGE_BOOT_FILES += "${IMAGE_SR2_HS_FS_FILES}"
  # Since default on J721e is for GP, add a version for SR2.0 HS-SE
-IMAGE_BOOT_FILES += "tiboot3-j721e_sr2-hs-evm.bin"
-IMAGE_BOOT_FILES += "sysfw-j721e_sr2-hs-evm.itb"
+IMAGE_SR2_HS_SE_FILES = "tiboot3-j721e_sr2-hs-evm.bin 
sysfw-j721e_sr2-hs-evm.itb"
+IMAGE_SR2_HS_SE_FILES:bsp-mainline = ""
+IMAGE_BOOT_FILES += "${IMAGE_SR2_HS_SE_FILES}"
  TFA_BOARD = "generic"
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17754): 
https://lists.yoctoproject.org/g/meta-ti/message/17754
Mute This Topic: https://lists.yoctoproject.org/mt/106655976/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to