On Thu, Apr 15, 2021 at 2:12 AM Bertrand Marquis
<[email protected]> wrote:
>
> Hi Christopher,
>
> > On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org
> > <[email protected]> wrote:
> >
> > Added as non-default, retaining the Xen 4.14 recipes as the default
> > preferred version for the Hardknott release.
> >
> > Signed-off-by: Christopher Clark <[email protected]>
> > ---
> > recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
> > recipes-extended/xen/xen_4.15.bb | 21 +++++++++++++++++++++
> > 2 files changed, 41 insertions(+)
> > create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
> > create mode 100644 recipes-extended/xen/xen_4.15.bb
> >
> > diff --git a/recipes-extended/xen/xen-tools_4.15.bb
> > b/recipes-extended/xen/xen-tools_4.15.bb
> > new file mode 100644
> > index 0000000..d8cb846
> > --- /dev/null
> > +++ b/recipes-extended/xen/xen-tools_4.15.bb
> > @@ -0,0 +1,20 @@
> > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > +
> > +XEN_REL ?= "4.15"
> > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > +
> > +SRC_URI = " \
> > + git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > + file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
> > + "
> > +
> > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > +
> > +PV = "${XEN_REL}+stable${SRCPV}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +DEFAULT_PREFERENCE ??= "-1"
>
> we have a file meta-virt-default-versions.inc in conf/distro/include
>
> Shouldn’t we use that file and set PREFERRED_VERSION instead of using default
> preference in each recipe ?
I wasn't aware of that file so hadn't considered it -- it's not
obvious as a place to look to understand how the version of Xen is
being set, or that it will change the default version of Xen according
to whether the DISTRO_FEATURES includes 'virtualization'. So I am not
sure that we should do that.
(As an aside, there's meta-virt-xen.inc in that directory that I would
like to retire and remove by making improvements elsewhere, for
similar reasons.)
> Something like:
> PREFERRED_VERSION_xen ?= "4.14%"
> PREFERRED_VERSION_xen-tools ?= "4.14%"
>
> This would prevent modifying the recipes when we change the default version.
I think I would prefer to modify the recipes when the default version
is changed, to make it a clear localized change in the Xen recipe
directory.
Would that be acceptable?
Christopher
>
> Cheers
> Bertrand
>
> > +
> > +require xen.inc
> > +require xen-tools.inc
> > diff --git a/recipes-extended/xen/xen_4.15.bb
> > b/recipes-extended/xen/xen_4.15.bb
> > new file mode 100644
> > index 0000000..49268cc
> > --- /dev/null
> > +++ b/recipes-extended/xen/xen_4.15.bb
> > @@ -0,0 +1,21 @@
> > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > +
> > +XEN_REL ?= "4.15"
> > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > +
> > +SRC_URI = " \
> > + git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > + file://xen-arm64-implement-atomic-fetch-add.patch \
> > +
> > file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
> > \
> > + "
> > +
> > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > +
> > +PV = "${XEN_REL}+stable${SRCPV}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +DEFAULT_PREFERENCE ??= "-1"
> > +
> > +require xen.inc
> > +require xen-hypervisor.inc
> > --
> > 2.25.1
> >
> >
> >
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6393):
https://lists.yoctoproject.org/g/meta-virtualization/message/6393
Mute This Topic: https://lists.yoctoproject.org/mt/82105875/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
