Hi,
> On 16 Apr 2021, at 03:24, Bruce Ashfield <[email protected]> wrote:
>
> On Thu, Apr 15, 2021 at 3:24 PM Christopher Clark
> <[email protected]> wrote:
>>
>> On Thu, Apr 15, 2021 at 2:12 AM Bertrand Marquis
>> <[email protected]> wrote:
>>>
>>> Hi Christopher,
>>>
>>>> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org
>>>> <[email protected]> wrote:
>>>>
>>>> Added as non-default, retaining the Xen 4.14 recipes as the default
>>>> preferred version for the Hardknott release.
>>>>
>>>> Signed-off-by: Christopher Clark <[email protected]>
>>>> ---
>>>> recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
>>>> recipes-extended/xen/xen_4.15.bb | 21 +++++++++++++++++++++
>>>> 2 files changed, 41 insertions(+)
>>>> create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
>>>> create mode 100644 recipes-extended/xen/xen_4.15.bb
>>>>
>>>> diff --git a/recipes-extended/xen/xen-tools_4.15.bb
>>>> b/recipes-extended/xen/xen-tools_4.15.bb
>>>> new file mode 100644
>>>> index 0000000..d8cb846
>>>> --- /dev/null
>>>> +++ b/recipes-extended/xen/xen-tools_4.15.bb
>>>> @@ -0,0 +1,20 @@
>>>> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
>>>> +
>>>> +XEN_REL ?= "4.15"
>>>> +XEN_BRANCH ?= "stable-${XEN_REL}"
>>>> +
>>>> +SRC_URI = " \
>>>> + git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
>>>> + file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
>>>> + "
>>>> +
>>>> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
>>>> +
>>>> +PV = "${XEN_REL}+stable${SRCPV}"
>>>> +
>>>> +S = "${WORKDIR}/git"
>>>> +
>>>> +DEFAULT_PREFERENCE ??= "-1"
>>>
>>> we have a file meta-virt-default-versions.inc in conf/distro/include
>>>
>>> Shouldn’t we use that file and set PREFERRED_VERSION instead of using
>>> default
>>> preference in each recipe ?
>>
>> I wasn't aware of that file so hadn't considered it -- it's not
>> obvious as a place to look to understand how the version of Xen is
>> being set, or that it will change the default version of Xen according
>> to whether the DISTRO_FEATURES includes 'virtualization'. So I am not
>> sure that we should do that.
>
> Having .inc files with lists of centralized versions is historically
> what has been done and tcmode-default.inc still does.
>
> We actually do only want those preferred versions to kick in when a
> distro feature is set (xen, virtualization .. whatever), since that
> means we can include the layer and it won't change anything unless the
> features are turned on.
>
>> (As an aside, there's meta-virt-xen.inc in that directory that I would
>> like to retire and remove by making improvements elsewhere, for
>> similar reasons.)
>>
>>> Something like:
>>> PREFERRED_VERSION_xen ?= "4.14%"
>>> PREFERRED_VERSION_xen-tools ?= "4.14%"
>>>
>>> This would prevent modifying the recipes when we change the default version.
>>
>> I think I would prefer to modify the recipes when the default version
>> is changed, to make it a clear localized change in the Xen recipe
>> directory.
>
> I can see the advantage of both approaches.
>
> The problem with the DEFAULT_PREFERENCE, is that just as many people
> have no idea what it does, how layer ordering does (or doesn't) impact
> it, etc. It is a bit harder to grok than an explicitly listed version
> (and you'll get a warning if a requested version isn't available,
> etc). But of course DEFAULT_PREFERENCE exists for a reason .. and
> this is one of them. I think it does come down to preference and
> consistency.
>
> I do lean towards the .inc myself, since we need them for other
> coordinating features in the layer(s), but I'm far from insisting on
> that approach.
I do think that the DEFAULT_PREFERENCE is kind of implicit so hard
to get for a user.
Where the PREFERRED_VERSION is clear and easy to overload in
your local.conf when you want to use something different.
Cheers
Bertrand
>
> Bruce
>
>> Would that be acceptable?
>>
>> Christopher
>>
>>>
>>> Cheers
>>> Bertrand
>>>
>>>> +
>>>> +require xen.inc
>>>> +require xen-tools.inc
>>>> diff --git a/recipes-extended/xen/xen_4.15.bb
>>>> b/recipes-extended/xen/xen_4.15.bb
>>>> new file mode 100644
>>>> index 0000000..49268cc
>>>> --- /dev/null
>>>> +++ b/recipes-extended/xen/xen_4.15.bb
>>>> @@ -0,0 +1,21 @@
>>>> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
>>>> +
>>>> +XEN_REL ?= "4.15"
>>>> +XEN_BRANCH ?= "stable-${XEN_REL}"
>>>> +
>>>> +SRC_URI = " \
>>>> + git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
>>>> + file://xen-arm64-implement-atomic-fetch-add.patch \
>>>> +
>>>> file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>>> \
>>>> + "
>>>> +
>>>> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
>>>> +
>>>> +PV = "${XEN_REL}+stable${SRCPV}"
>>>> +
>>>> +S = "${WORKDIR}/git"
>>>> +
>>>> +DEFAULT_PREFERENCE ??= "-1"
>>>> +
>>>> +require xen.inc
>>>> +require xen-hypervisor.inc
>>>> --
>>>> 2.25.1
>>>>
>>>>
>>>>
>>>>
>>>
>>> IMPORTANT NOTICE: The contents of this email and any attachments are
>>> confidential and may also be privileged. If you are not the intended
>>> recipient, please notify the sender immediately and do not disclose the
>>> contents to any other person, use it for any purpose, or store or copy the
>>> information in any medium. Thank you.
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6397):
https://lists.yoctoproject.org/g/meta-virtualization/message/6397
Mute This Topic: https://lists.yoctoproject.org/mt/82105875/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
