On Tue, Nov 7, 2023 at 5:10 AM Sverdlin, Alexander <[email protected]> wrote: > > Hi Bruce! > > On Mon, 2023-11-06 at 19:57 -0500, Bruce Ashfield wrote: > > > As I keep looking at it, there's very little in the .inc file that isn't > > > controlled by a distro feature, so there's only small tweaks needed > > > to make sure that only fragments and kernel features that are > > > quite well targeted are enabled. > > > > > > Having the kernel-cache as a dependency is not much to ask, > > > combined with the ability to use them to configure kernels > > > properly and audit the results. > > > > > > The hours (more like weeks and months) spent debugging runtime > > > issues due to incorrectly configured kernels has been huge over > > > the lifetime of meta-virtualization. Asking for a few fragments to > > > be downloaded (which can be mirrored) is minor in the scope of > > > things. > > > > > > Which is why if a kernel type that can merge fragments, but yet > > > is disabling the feature specification, the layer should emit a > > > warning. I'd then have another variable which inhibits the warning > > > message. Since that is something I can ask about in bug reports > > > and until the warning message is re-enabled, the reporter is on > > > their own. > > > > My solution is now in master-next: > > > > https://git.yoctoproject.org/meta-virtualization/commit/?h=master-next&id=45c2297a916516e5fc7b82dab46c4719590813b7 > > I've tested your solution and it solves the issue on my side, > thank you for addressing it so quickly! > > There is a problem in the warning code though, namely a typo here: > > skip_kernel_include_enabled = d.getVar('SKIP_META_VIRT_KERNEL_INLUDE') > > if it would be > > skip_kernel_include_enabled = d.getVar('SKIP_META_VIRT_KERNEL_INCLUDE') > > the warning would be emitted as expected. After the change both emitting > and silencing the warning works fine.
oops! I just force pushed the fix to master-next. Bruce > > -- > Alexander Sverdlin > Siemens AG > www.siemens.com -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8440): https://lists.yoctoproject.org/g/meta-virtualization/message/8440 Mute This Topic: https://lists.yoctoproject.org/mt/102416724/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/leave/6693005/21656/1014668956/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
