I think one per recipe (or few related ones like runc*bb) would be easier to review in this case.
On Thu, May 23, 2024 at 12:51 AM Theodore A. Roth <[email protected]> wrote: > > > On Wed, May 22, 2024 at 4:05 PM Martin Jansa <[email protected]> wrote: >> >> Hi, >> >> I can confirm that I'm seeing the same build failures since this >> morning and agree that the recipes need to adapt to: >> https://git.openembedded.org/openembedded-core/commit/?id=cc4ec43a2b657fb4c58429ab14f1edc2473c1327 >> >> I've started with some WIP changes and fixed some of them in: >> https://github.com/shr-project/meta-virtualization/commit/30a85c0319c253632206b0d2c2c483f11a490939 >> but than got side tracked by some other build failures and not sure >> when I'll be able to get back to it. >> >> I've also asked Bruce on IRC and he is aware of the issues, but might >> not have time to resolve it soon, so if you have the changes ready, >> then please send them to ML for Bruce to review when he has time and >> I'll happily build test them as well. >> >> Cheers, > > > Should I send a single patch fixing a bunch of recipes (aka many destsuffix > fixes at once) or one patch per recipe? > > Ted Roth > >> >> >> On Wed, May 22, 2024 at 11:52 PM Theodore A. Roth via >> lists.yoctoproject.org <[email protected]> >> wrote: >> > >> > Hi, >> > >> > In our CI builds for multiple projects using meta-virtualization master >> > branch, we are >> > seeing some build failures for some recipes that use GO: >> > >> > * go-md2man >> > * runc-opencontainers >> > * docker-moby >> > * podman >> > * buildah >> > * cni >> > >> > I think I've narrowed the breakages down to this commit to oe-core from >> > Richard Purdie: >> > >> > * https://lists.openembedded.org/g/openembedded-core/message/199614 >> > >> > The fixes for our builds seem simple enough. Just add >> > ';destsuffix=${GO_SRCURI_DESTSUFFIX}' >> > to the SRC_URI. For example: >> > >> > --- >> > >> > diff --git a/recipes-devtools/go/go-md2man_git.bb >> > b/recipes-devtools/go/go-md2man_git.bb >> > index 1d96bb1b..73d8d167 100644 >> > --- a/recipes-devtools/go/go-md2man_git.bb >> > +++ b/recipes-devtools/go/go-md2man_git.bb >> > @@ -9,7 +9,7 @@ BBCLASSEXTEND = "native" >> > GO_IMPORT = "github.com/cpuguy83/go-md2man" >> > #GO_INSTALL = "${GO_IMPORT}/bin/go-md2man" >> > >> > -SRC_URI = "git://${GO_IMPORT}.git;branch=master;protocol=https" >> > +SRC_URI = >> > "git://${GO_IMPORT}.git;branch=master;protocol=https;destsuffix=${GO_SRCURI_DESTSUFFIX}" >> > >> > SRCREV = "f79a8a8ca69da163eee19ab442bedad7a35bba5a" >> > PV = "1.0.10+git" >> > >> > --- >> > >> > I plan to finish my testing for our breakages and submit some patches, but >> > it feels like there are many >> > more recipes that will need this change made (basically anything that is >> > using 'inherit go'). >> > >> > I'm a bit reluctant to submit patches for recipes we are not using (and >> > testing) even if they seem like >> > mechanical changes, but I wanted to let the list know what I have found. >> > >> > Ted Roth >> > >> > >> >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8740): https://lists.yoctoproject.org/g/meta-virtualization/message/8740 Mute This Topic: https://lists.yoctoproject.org/mt/106252100/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
