On 2019年07月26日 02:28, Bruce Ashfield wrote:
On Wed, Jul 24, 2019 at 11:43 PM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Since cri-o of meta-virtualization depends on
libselinux which comes from selinux, add missing
layer depends back.

This is already covered in the README. Since cri-o is optional, I
didn't want it to be a hard depends.

Not matter cri-o is optional or not, but first the cri-o recipe indeed exists in meta-virtualization layer until now as ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and second there is below logic in ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and clearly it depends on libselinux.
DEPENDS = " \
    glib-2.0 \
    btrfs-tools \
    gpgme \
    ostree \
    libdevmapper \
    libseccomp \
    libselinux \
    "

So we should add the layer depends selinux(libselinux in selinux layer) for meta-virtualization layer, otherwise there comes below error when do yocto compliance check: ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it)

ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux'
]

Thanks,


Required for cri-o:
URI: git://github.com/advancedtelematic/meta-updater
URI: git://git.yoctoproject.org/meta-selinux
URI: git://git.yoctoproject.org/meta-security
branch: master
revision: HEAD
prio: default


I haven't seen a way to do a conditional depends .. has anyone else ?

Bruce


Signed-off-by: Mingli Yu <[email protected]>
---
  conf/layer.conf | 1 +
  1 file changed, 1 insertion(+)

diff --git a/conf/layer.conf b/conf/layer.conf
index be1f222..23efcb8 100644
--- a/conf/layer.conf
+++ b/conf/layer.conf
@@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
      networking-layer \
      filesystems-layer \
      meta-python \
+    selinux \
  "

  # webserver: naigos requires apache2
--
2.7.4



--
_______________________________________________
meta-virtualization mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-virtualization

Reply via email to