On Wed, Jul 31, 2019 at 3:23 AM Yu, Mingli <[email protected]> wrote:
> Ping. > > I'm currently out of the office and won't be back until Aug 7th, so I'm not getting to any reviews/merges as fast as I normally do. The approach that this takes is interesting. I personally don't have a problem with it, but I suppose things don't scale as well if everyone did depends like this on a per-recipe basis. I'm going to stage the patch and test it locally, while I wait to see if anyone else has any objections to the approach Bruce > Thanks, > > On 2019年07月26日 17:10, [email protected] wrote: > > From: Mingli Yu <[email protected]> > > > > cri-o depends on ostree, libselinux and libseccomp > > and we should check if the layer which provides these > > recipes exist or not before go on. > > > > Signed-off-by: Mingli Yu <[email protected]> > > --- > > recipes-containers/cri-o/cri-o_git.bb | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/recipes-containers/cri-o/cri-o_git.bb > b/recipes-containers/cri-o/cri-o_git.bb > > index c27aef7..b0c0ce4 100644 > > --- a/recipes-containers/cri-o/cri-o_git.bb > > +++ b/recipes-containers/cri-o/cri-o_git.bb > > @@ -42,6 +42,28 @@ RDEPENDS_${PN} = " \ > > cni \ > > " > > > > +python __anonymous() { > > + msg = "" > > + # ERROR: Nothing PROVIDES 'libseccomp' (but > /buildarea/layers/meta-virtualization/recipes-containers/cri-o/ > cri-o_git.bb DEPENDS on or otherwise requires it). > > + # ERROR: Required build target 'meta-world-pkgdata' has no > buildable providers. > > + # Missing or unbuildable dependency chain was: > ['meta-world-pkgdata', 'cri-o', 'libseccomp'] > > + if 'security' not in d.getVar('BBFILE_COLLECTIONS').split(): > > + msg += "Make sure meta-security should be present as it > provides 'libseccomp'" > > + raise bb.parse.SkipRecipe(msg) > > + # ERROR: Nothing PROVIDES 'ostree' (but > /buildarea/layers/meta-virtualization/recipes-containers/cri-o/ > cri-o_git.bb DEPENDS on or otherwise requires it). > > + # ERROR: Required build target 'meta-world-pkgdata' has no > buildable providers. > > + # Missing or unbuildable dependency chain was: > ['meta-world-pkgdata', 'cri-o', 'ostree'] > > + elif 'cube' not in d.getVar('BBFILE_COLLECTIONS').split(): > > + msg += "Make sure meta-cube should be present as it provides > 'ostree'" > > + raise bb.parse.SkipRecipe(msg) > > + # ERROR: Nothing PROVIDES 'libselinux' (but > /buildarea/layers/meta-virtualization/recipes-containers/cri-o/ > cri-o_git.bb DEPENDS on or otherwise requires it). > > + # ERROR: Required build target 'meta-world-pkgdata' has no > buildable providers. > > + # Missing or unbuildable dependency chain was: > ['meta-world-pkgdata', 'cri-o', 'libselinux'] > > + elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split(): > > + msg += "Make sure meta-selinux should be present as it provides > 'libselinux'" > > + raise bb.parse.SkipRecipe(msg) > > +} > > + > > PACKAGES =+ "${PN}-config" > > > > RDEPENDS_${PN} += " virtual/containerd virtual/runc" > > > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-- _______________________________________________ meta-virtualization mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-virtualization
