Hi guys!

We found something bad (we think).

I've posted this on freenode #yocto just today.

meta-xilinx-tools/conf/layer.conf has INHERIT += "xsct-tc" and in this bbclass, 
it messes with PATH. This has the effect that ANY random xilinx or not recipe 
discovers binaries in these XSCT paths. Those binaries were obviously not 
mentioned in their DEPENDS. This causes those recipes to change the way they 
configure and/or build their artifacts.

Right now we have noticed that gtk-doc and gdk-pixbuf are "contaminated" with 
tmp/sysroots-xsct/Scout/2019.1/bin/xsltproc. In the case of gdk-pixbuf, it 
causes the recipe's meson.build 
https://github.com/GNOME/gdk-pixbuf/blob/a5f74989c58aa2df643c5fd66c99bc58cd62c4e5/docs/meson.build#L69
 to generate man files always. We found out because during these steps, it 
reaches for 
http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl which 
failed randomly in our CI builds.

Way more unintended things could happen as a result of these xsct specific 
paths being in EVERYONE'S PATH variable.

The fix appeared quite simple as changing layer.conf to do INHERIT += 
"xsct-tarball" instead, which actually contains the eventHandler for 
BuildStarted, the reason for all this. It does fix the unwanted discovery of 
binaries, but unfortunately, I have to force build these recipes since the 
change I did doesn't affect sstate hashes (PATH is not part of any hash, and it 
shouldn't).

Maxime and I were thinking that the xsct tarball could be refactored into a 
recipe which bundles up the toolchain perhaps so that only recipes that need 
the toolchain (those that inherit xsct-tc.bbclass) would get the toolchain in 
their recipe-sysroot.

Any clues, insights, insults?

If you want to chat about this, join us on freenode #yocto @jeff_dagenais 
@roussinm

Cheers!
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4586): 
https://lists.yoctoproject.org/g/meta-xilinx/message/4586
Mute This Topic: https://lists.yoctoproject.org/mt/68534996/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-xilinx/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to