Hi JD, > -----Original Message----- > From: Jean-Francois Dagenais <[email protected]> > Sent: Friday, December 13, 2019 9:46 AM > To: [email protected] > Cc: Manjukumar Harthikote Matha <[email protected]>; Maxime > Roussin-Bélanger <[email protected]> > Subject: meta-xilinx-tools: incorrect modification of PATH > > Hi guys! > > We found something bad (we think). > > I've posted this on freenode #yocto just today. > > meta-xilinx-tools/conf/layer.conf has INHERIT += "xsct-tc" and in this > bbclass, it > messes with PATH. This has the effect that ANY random xilinx or not recipe > discovers binaries in these XSCT paths. Those binaries were obviously not > mentioned in their DEPENDS. This causes those recipes to change the way they > configure and/or build their artifacts. > > Right now we have noticed that gtk-doc and gdk-pixbuf are "contaminated" with > tmp/sysroots-xsct/Scout/2019.1/bin/xsltproc. In the case of gdk-pixbuf, it > causes the recipe's meson.build https://github.com/GNOME/gdk- > pixbuf/blob/a5f74989c58aa2df643c5fd66c99bc58cd62c4e5/docs/meson.build# > L69 to generate man files always. We found out because during these steps, it > reaches for > http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl > which failed randomly in our CI builds. > > Way more unintended things could happen as a result of these xsct specific > paths being in EVERYONE'S PATH variable. >
Weird, have to replicate and see whats going on here. > The fix appeared quite simple as changing layer.conf to do INHERIT += "xsct- > tarball" instead, which actually contains the eventHandler for BuildStarted, > the > reason for all this. It does fix the unwanted discovery of binaries, but > unfortunately, I have to force build these recipes since the change I did > doesn't > affect sstate hashes (PATH is not part of any hash, and it shouldn't). > xsct-tc inherits xsct-tarball, not sure how this will fix the issue you are seeing. https://github.com/Xilinx/meta-xilinx-tools/blob/rel-v2019.2/classes/xsct-tc.bbclass#L1 > Maxime and I were thinking that the xsct tarball could be refactored into a > recipe which bundles up the toolchain perhaps so that only recipes that need > the > toolchain (those that inherit xsct-tc.bbclass) would get the toolchain in > their > recipe-sysroot. > Does this help? https://github.com/Xilinx/meta-xilinx-tools/commit/143bc2f3e622805e432584a587cf32cfce02d3b1#diff-e0bda8197e58839fe38b56adbfec55ff Thanks, Manju > Any clues, insights, insults? > > If you want to chat about this, join us on freenode #yocto @jeff_dagenais > @roussinm > > Cheers!
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#4587): https://lists.yoctoproject.org/g/meta-xilinx/message/4587 Mute This Topic: https://lists.yoctoproject.org/mt/68534996/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-xilinx/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
