On 01-08-16 20:54, Manjukumar Harthikote Matha wrote:
Hi Nathan,
On 07/31/2016 06:15 AM, Nathan Rossi wrote:
On Sat, Jul 30, 2016 at 4:44 AM, Manjukumar Harthikote Matha
<[email protected]> wrote:
Hi Mike,
On 07/26/2016 03:09 AM, Mike Looijmans wrote:
<...>
# kernel modules for ZynqMP
-MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS_append_zynqmp = "
kernel-module-mali-modules"
+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS_append_zynqmp = "
kernel-module-mali"
I was following the guidelines from Yocto documents
http://www.yoctoproject.org/docs/1.6.1/kernel-dev/kernel-dev.html#incorporating-out-of-tree-modules
My understanding is that when we inherit module.bbclass, it will package
with "kernel-module-" prefix, hence we just use that for
MACHINE_ESSENTIAL_EXTRA packages.
That document states that the "kernel-module-*" matches the name of
the actual module, not the PN for the recipe. Written in that document
as "Where the value is derived by appending the module filename
without the .ko extension to the string "kernel-module-"".
Thats what I had missed, I was checking to see if my understanding was
incorrect, thanks :)
This matches the actual output that is built, with the kernel-module
being located in a package with the name "kernel-module-mali".
So we don't need the other patch in mali-modules.bb which has PROVIDES
+= "kernel-module-mali". I think it would work without it since it
builds a package named kernel-module-mali
The PROVIDES was required, because the 'kernel-module-mali' name isn't
known at parse time yet, only when do_install has run. So anything that
(R)DEPENDS on kernel-module-mali would wrongly assume that the kernel
will provide it, and the module would still not be built. It would only
be available if you manually add a DEPENDS on the recipe name.
The simplest and most straightforward solution is to name the recipe
such that it matches the package being built. Then all this trickery
isn't needed at all.
packages-split/kernel-module-mali/lib/modules/4.4.0-xilinx/extra/mali.ko
So I believe Mike's patch is correct in fixing up the M*_E*_E*_R*
append. Manju could you confirm this is as expected? and the .ko is
not supposed to be instead named 'mali-modules' (which would be an odd
name for a singular module ;)).
Initial thought process was to see if we would include ump.ko as well,
but it did not happen. It is definitely building package
kernel-module-mali-${PV}.rpm
Thanks
Manju
--
Mike Looijmans
--
_______________________________________________
meta-xilinx mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-xilinx
