Konstantin Ryabitsev <[email protected]> wrote: > Yep, that was the culprit. After installing pkg-config, gcf2 builds and tests > pass. I still have this while running "make test":
Good to know. We'll have to document that when adding libgit2 stuff to the already-huge INSTALL file. > t/git.t ...................... 1/? fatal: Needed a single revision > > But I do get "All tests successful" in the end, so I assume that's the > expected condition. Yes, it was making sure errors got propagated properly. It always got lost in the "make -j4 check" parallel output for me :x --------8<--------- Subject: [PATCH] t/git.t: quiet intentional git-rev-parse failure It can get confusing, especially when running non-parallel "make test" Link: https://public-inbox.org/meta/[email protected]/ --- t/git.t | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/git.t b/t/git.t index bc1dea50..844e0111 100644 --- a/t/git.t +++ b/t/git.t @@ -98,8 +98,10 @@ if (1) { $gcf->qx(qw(repack -adq)); ok($gcf->packed_bytes > 0, 'packed size is positive'); - $gcf->qx(qw(rev-parse --verify bogus)); - isnt($?, 0, '$? set on failure'.$?); + my $rdr; + open $rdr->{2}, '+>', '/dev/null' or xbail "open $!"; + $gcf->qx([qw(rev-parse --verify bogus)], undef, $rdr); + isnt($?, 0, '$? set on failure: '.$?); } SKIP: { -- unsubscribe: one-click, see List-Unsubscribe header archive: https://public-inbox.org/meta/
