Konstantin Ryabitsev <[email protected]> wrote:
> On Thu, Sep 09, 2021 at 09:23:48PM +0000, Eric Wong wrote:
> > > Annoyingly, after I blow away the container to start fresh, I get:
> > >
> > > t/gcf2.t ..................... skipped: PublicInbox::Gcf2 missing for
> > > t/gcf2.t
> > >
> > > That means gcf2 isn't getting built, right?
> >
> > Yeah, assuming all dependencies are there;
> > is PERL_INLINE_DIRECTORY set (or ~/.cache/public-inbox/inline-c exists?)
>
> Ah, yes, when I build as part of the dockerfile image, that dir is absent.
> It shouldn't matter for actual usage, though -- so we can ignore this.
>
> Sorry for a lot of noise about it, just want to make sure I got everything
> working. :)
>
> I'll follow up with my draft instructions on how to get things running with
> toolbox.
No worries, I think the test can show diagnostic info without
being too alarming for optional dependencies:
--------8<--------
Subject: [PATCH] test_common: print diagnostic for missing dependencies
The "#" prefix should prevent it from being too alarming if
a dependency is expected to be missing, but still useful if a
dependency is misconfigured.
---
lib/PublicInbox/TestCommon.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 83dcf650..2e3e9ecc 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -144,6 +144,7 @@ sub require_mods {
eval "require $mod";
}
if ($@) {
+ diag "require $mod: $@";
push @need, $mod;
} elsif ($mod eq 'IO::Socket::SSL' &&
# old versions of IO::Socket::SSL aren't supported
--
unsubscribe: one-click, see List-Unsubscribe header
archive: https://public-inbox.org/meta/
