[Microdia] Re: [PATCH] add sn9c20x-i420 decoder to libv4l-0.5.7

[GWater]

Vasily Khoruzhick schrieb:

On 11 January 2009 22:29:20 GWater wrote:

Vasily Khoruzhick schrieb:

On 11 January 2009 15:25:56 Hans de Goede wrote:

Vasily Khoruzhick wrote:

Hi, Hans

Recent sn9c20x driver written by microdia project
(http://groups.goolge.com/group/microdia) introduce new output format -
sn9c20x-i420. This format is actually scrambled yuv420, so it's very
easy and fast to convert it to yuv420. This patch adds sn9c20x-i420
decoder to the libv4l-0.5.7

Hi,

As you've probably already seen from the release mail, I've just
released libv4l-0.5.8, which includes your patch.

Is there any more image format conversion code inside the sn9c20x
driver? If so it would be really good to move that to userspace too,
once that is done the driver can be moved in to the mainline kernel (if
considered ready by its devs)

Nope, there's no more image format conversion code inside the sn9c20x
driver, but I really don't know if it's time to move driver into the
mainline kernel. I think we should discuss this question on the microdia
maillist.

Regards,

Hans

Regards
Vasily

Got myself the 0.5.8 release from fedora updates-testing and it works
nicely with my bandwidth-dependent JPEG-compression patch.

Therefore I'd like to push that patch now. I attached it again. Maybe
someone wants add something to the two lines I wrote ;) .

GWater

Yep, I want to make a little modification:

jpeg var should be set to 0 by default, and it should be forced to 1 on FULL and HALF -speed devices. In this case user can enable jpeg if he wants to :)

I thought about that, too.



My patch however does still allow everyone to choose:


Please consider this.

GWater

However I got to the conlcusion that this way people with LOW- and FULL- speed devices can't disable JPEG. LOW- and FULL-speed users can choose anyway and HIGH-speed users can use the "bandwidth" setting to work around the forced non-JPEG output. And a bandwidth (alternate-)setting of 7 should still offer enough speed for JPEG.

signature.asc
Description: OpenPGP digital signature