I think if we do change this something like hans suggest would be best. Whatever a user puts for the jpeg module parameter should really be respected instead of overwriting it just because teh driver thinks that is better. For example when using our i420 decoder at 640x480 it causes issues with my usb touchpad losing sync and my mouse going crazy. So i generally prefer using the jpeg format whcih works quite well for me and would rather they driver respect that choice.
On Sun, Jan 11, 2009 at 5:04 PM, Vasily Khoruzhick <[email protected]> wrote: > On 11 January 2009 23:57:17 Hans de Goede wrote: > >> Why not just make the jpeg flag an int, set it to -1 by default and make >> the speed check: >> >> if (jpeg == -1) { >> if (dev->udev->speed == USB_SPEED_HIGH && bandwidth == 8) >> jpeg = 0; >> else >> jpeg = 1; >> } >> >> Then default jpeg will depend on speed, and the user can force it either >> way. >> >> Regards, >> >> Hans > > Good solution too, but I think jpeg should be always enable on usb1, as usb1 > has no enought bandwidth for i420 or bayer; and it should be optional on usb2 > --~--~---------~--~----~------------~-------~--~----~ Lets make microdia webcams plug'n play, (currently plug'n pray) To post to this group, send email to [email protected] Visit us online https://groups.google.com/group/microdia -~----------~----~----~----~------~----~------~--~---
