Hi Soham,

> I am submitting a patch for the feature Declining Balance - Equal
> Principal Installments based on rev 12276
>
http://www.mifos.org/developers/wiki/DecliningBalanceInterestCalculation
With
> EqualPrincipalInstallment  

Thanks for the patch!  It has been committed as revision 12333.

There will be some additional validation done by the Mifos team, so we
may have additional questions related to this, but it looks good.

> I tried to follow all the recommended steps, however this being my
> first attempt, please let me know if I missed anything and also
> provide feedback/suggestions.  

You've done a great job implementing this and providing good test cases
for it.  Thank you for contributing a nice piece of work to the Mifos
project.  Note that some changes were made in order to commit it, but
these had to do with changes which occurred between when you submitted
your patch and when we were able to review it (e.g. Database version
number changes).

Cheers,
--Van



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Reply via email to