Hi Soham, > Thanks for applying the changes, and I hope to contribute more in > future.
We'll look forward to that! > I did notice one thing though, the latest-data.sql does not seem to > have the DB changes for this feature, i.e. the database upgrade to > 175, and the corresponding changes for the lookup values. I think you > might have missed checking that in and I assume that is required if > we do the "clean database" build. The changes you made to latest-data.sql needed to be rearranged a bit since there has been some major restructuring done related to internationalization work. Fisheye is a useful tool for tracking what changes have been committed in a given revision: http://fisheye4.cenqua.com/changelog/mifos/ You can see all the change made for your patch commit here: http://fisheye4.cenqua.com/changelog/mifos/?cs=12333 The particular changes that were made to latest-data.sql can be seen in the following diff: http://fisheye4.cenqua.com/browse/mifos/trunk/mifos/sql/latest-data.sql? r1=12321&r2=12333 Hopefully I didn't omit anything that should have been there, while rearranging the changes. Your changes did pass the test suite and I was able to exercise the feature and it worked. One change you will notice is that the text to display for the new interest calculation is no longer in latest-data.sql (the LOOKUP_VALUE_LOCALE entry now has a null value). Instead this has been moved to a properties file: http://fisheye4.cenqua.com/browse/mifos/trunk/mifos/src/org/mifos/config /localizedResources/LookupValueMessages.properties?r1=12319&r2=12333 We will be posting some documentation that describes these changes in how to deal with static text in order to support Internationalization. Cheers, --Van ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
