[
http://mifosforge.jira.com/browse/MIFOS-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57506#action_57506
]
Udai Gupta commented on MIFOS-2866:
-----------------------------------
at r17173 in trunk, WeekDaysEntity and RankOfDaysEntity is replaced by WeekDay
and RankOfDay enums.
Database upgrade to remove the tables and lookup entries is still remaining
> Replace WeekDaysEntity and RankOfDaysEntity with enums
> ------------------------------------------------------
>
> Key: MIFOS-2866
> URL: http://mifosforge.jira.com/browse/MIFOS-2866
> Project: mifos
> Issue Type: Improvement
> Components: Misc
> Affects Versions: Release 1.5
> Reporter: Udai Gupta
> Assignee: Udai Gupta
> Fix For: Shamim D
>
>
> WeekDaysEntity and RankOfDaysEntity can be easily replaced with enums.
> - No customization is allowed in these entities
> - legacy localization lookup is broken as there are no values for other
> locale in lookup table.
> - It already uses enum internally so there should be no issue with adding new
> member if needed as that would have required to add that member in table +
> enum.
> - FiscalCalendarRules already has utility methods for replacing logic around
> WeekDaysEntity like workingdays and startingday
> Why have table for the mapping of "weekdays" and "rank of day" when we are
> indirectly doing it using enum.
> legacy Localization (using lookup tables) can replaced with new property
> files based localization for these entities. Initially default localization
> should be enough.
> This change will remove the need of expensive/unnecessary join operation with
> weekDays and RankOfDays on retrieval of MeetingRecurrence and LoanAccount
> from hibernate layer.
> It will simplify the code and also we can map existing values for WeekDay an
> RankOfDay in tables like MeetingDetails and LoanAcount, hence there will be
> no major database upgrade required.
> One database upgrade would required to remove the entries from lookup tables
> and dropping week_of_day_master and rank_of_days_master and FKs. this upgrade
> is completely independent of the work that would be required to replace these
> entities with enums
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
