[
http://mifosforge.jira.com/browse/MIFOS-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udai Gupta updated MIFOS-2866:
------------------------------
Description:
WeekDaysEntity and RankOfDaysEntity can be replaced with enums as.
- No customization is allowed in these entities
- These entities represent concepts which is unchangeable.
- FiscalCalendarRules already has utility methods for replacing logic around
WeekDaysEntity like workingdays and startingday
Why have table for the mapping of "weekdays" and "rank of day" when we are
indirectly doing it using enum.
legacy Localization (using lookup tables) can replaced with new property files
based localization for these entities. Initially default localization should be
enough.
This change will remove the need of expensive/unnecessary join operation with
weekDays and RankOfDays on retrieval of MeetingRecurrence and LoanAccount from
hibernate layer.
It will simplify the code, mapping existing values for WeekDay an RankOfDay in
entities like MeetingRecurrence and LoanAcount, hence there will be change at
database level
One database upgrade would be required to dropping week_of_day_master and
rank_of_days_master and FKs. This upgrade is completely independent of the work
that would be required to replace these entities with enums.
Later in future we can replace values in table(related to MeetingRecurrence and
LoanAcount) like
1 to MONDAY
2 to TUESDAY
MySQL varchar or Enum type to make database more readable.
was:
WeekDaysEntity and RankOfDaysEntity can be easily replaced with enums.
- No customization is allowed in these entities
- legacy localization lookup is broken as there are no values for other locale
in lookup table.
- It already uses enum internally so there should be no issue with adding new
member if needed as that would have required to add that member in table +
enum.
- FiscalCalendarRules already has utility methods for replacing logic around
WeekDaysEntity like workingdays and startingday
Why have table for the mapping of "weekdays" and "rank of day" when we are
indirectly doing it using enum.
legacy Localization (using lookup tables) can replaced with new property files
based localization for these entities. Initially default localization should be
enough.
This change will remove the need of expensive/unnecessary join operation with
weekDays and RankOfDays on retrieval of MeetingRecurrence and LoanAccount from
hibernate layer.
It will simplify the code and also we can map existing values for WeekDay an
RankOfDay in tables like MeetingDetails and LoanAcount, hence there will be no
major database upgrade required.
One database upgrade would required to remove the entries from lookup tables
and dropping week_of_day_master and rank_of_days_master and FKs. this upgrade
is completely independent of the work that would be required to replace these
entities with enums
Fix Version/s: (was: Shamim D)
Marie E
The upgrade to drop week_of_day_master and rank_of_days_master will be after
next release and making a note that in the next release that these table has
been deprecated and should not be used for any purpose.
> Replace WeekDaysEntity and RankOfDaysEntity with enums
> ------------------------------------------------------
>
> Key: MIFOS-2866
> URL: http://mifosforge.jira.com/browse/MIFOS-2866
> Project: mifos
> Issue Type: Improvement
> Components: Misc
> Affects Versions: Release 1.5
> Reporter: Udai Gupta
> Assignee: Udai Gupta
> Fix For: Marie E
>
>
> WeekDaysEntity and RankOfDaysEntity can be replaced with enums as.
> - No customization is allowed in these entities
> - These entities represent concepts which is unchangeable.
> - FiscalCalendarRules already has utility methods for replacing logic around
> WeekDaysEntity like workingdays and startingday
> Why have table for the mapping of "weekdays" and "rank of day" when we are
> indirectly doing it using enum.
> legacy Localization (using lookup tables) can replaced with new property
> files based localization for these entities. Initially default localization
> should be enough.
> This change will remove the need of expensive/unnecessary join operation with
> weekDays and RankOfDays on retrieval of MeetingRecurrence and LoanAccount
> from hibernate layer.
> It will simplify the code, mapping existing values for WeekDay an RankOfDay
> in entities like MeetingRecurrence and LoanAcount, hence there will be change
> at database level
> One database upgrade would be required to dropping week_of_day_master and
> rank_of_days_master and FKs. This upgrade is completely independent of the
> work that would be required to replace these entities with enums.
> Later in future we can replace values in table(related to MeetingRecurrence
> and LoanAcount) like
> 1 to MONDAY
> 2 to TUESDAY
> MySQL varchar or Enum type to make database more readable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
