[
http://mifosforge.jira.com/browse/MIFOS-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57511#action_57511
]
johnwoodlock commented on MIFOS-2730:
-------------------------------------
Shahid, here's a reply from Jakub.
I think you should leave the database upgrade bit (dbunit datasets) and the po
files (translation) aside... that can be done when we apply the patch... and
just concentrate on code and test changes and the sql (that you've already
supplied). At least that reduces some of the complexity.
Overall, I think Jakub's main suggestion is to add at least one test in the
HiddenMandatoryConfigurationActionStrutsTest class.
----------------
Hi John,
I have to admit, that Mohammad chose the wrong issue ;) Adding new
mandatory/hidden field is really time-consuming, because:
* you have to add new entries to the field_configuration table
* the above means that all dbunit datasets need to be updated
* you have to support new entries in definehiddenmandatoryfields.jsp,
HiddenMandatoryConfigurationActionForm.java and
HiddenMandatoryConfigurationAction.java
* you should also update appropriate constants and property files
* the above means, that all po files need to be updated (according to
http://www.mifos.org/developers/wiki/AdminOnlineTranslationHOWTO)
* moreover, every jsp page with new mandatory/hidden fields should be also
updated
I have looked into Mohammad's patch and it looks quite ok (but I haven't
applied and tested it). However, he should also update the dbunit datasets and
po translation files.
Regarding the tests, he should add at least one to the
HiddenMandatoryConfigurationActionStrutsTest class (in order to check that new
fields are properly supported by this action). However, new hidden/mandatory
fields should be also manually tested. The problem with automated tests for
mandatory/hidden fields is that we should check every field on every jsp page
with various hidden/mandatory settings. The current status is that we have only
few such tests. I'm sure that Mohammad's fields aren't tested by any of the
currently available acceptance tests, so he can add one. However, I think that
new acceptance test isn't necessary in this case (this issue is very big even
without writing new acceptance tests).
I hope the above comments will be useful for you.
Yours sincerely,
Jakub.
---------
> Allow more fields to be mandatory
> ---------------------------------
>
> Key: MIFOS-2730
> URL: http://mifosforge.jira.com/browse/MIFOS-2730
> Project: mifos
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: Release 1.4
> Reporter: Sam Birney
> Assignee: Mohammad Shahiduzzaman
> Priority: Major
> Fix For: Gazelle Backlog
>
> Attachments: mifos-2730.patch, query.sql
>
>
> Would be very helpful if configuration is enabled to make more fields
> mandatory, since data entry people have a way of frequently skipping
> non-mandatory fields despite being trained not to do so. Fields that are
> desired to be able to make mandatory:
> * Client Middle Name
> * Government ID
> * Marital Status
> * Number of Children
> * Business Activities
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
