[
http://mifosforge.jira.com/browse/MIFOS-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57603#action_57603
]
johnwoodlock commented on MIFOS-2881:
-------------------------------------
Recommendation
==============
Remove the following tables from mifos:
COLL_SHEET
COLL_SHEET_CUSTOMER
COLL_SHEET_LOAN_DETAILS
COLL_SHEET_SAVINGS_DETAILS
And remove all mifos code, tests and infrastructure associated with them (quite
a bit).
Note:
There is code related to running the named query
"collectionSheet.extractCollectionSheetReportData" in
CollectionSheetBO.hbm.xml. This code (service) is used by the Birt
BatchCollectionSheetReport but it gets its data from the 'main' tables (such as
customer, account, loan_account, loan_schedule etc.) not the COLL_SHEET* tables
above.
Why
===
This CollectionSheetReportCachingTask batch job just reads coll_sheet &
coll_sheet_customer tables that have been populated by CollectionSheetTask
batch job. However, the CollectionSheetTask batch job is no longer run so it
just does many hundreds of thousand of queries that return nothing (depending
on how many customers are on the database).
The CollectionSheetTask batch job (used to) populates all 4 COLL_SHEET* tables
above.
The original intention of CollectionSheetReportCachingTask may have been to
ensure this data was in cache so then when a collection sheet report was run
(originally using data on COLL_SHEET* tables) response was a little quicker.
Collection sheet reports have turned out to be done differently (using the
named query above via a collectionsheetreportservice method).
There's no chance of going back to the COLL_SHEET approach. Leaving the
COLL_SHEET legacy cause a deal of confusion.
> CollectionSheetReportCachingTask - remove batch job and take out code
> ---------------------------------------------------------------------
>
> Key: MIFOS-2881
> URL: http://mifosforge.jira.com/browse/MIFOS-2881
> Project: mifos
> Issue Type: Improvement
> Components: Batch jobs
> Affects Versions: Release 1.5
> Reporter: johnwoodlock
> Assignee: johnwoodlock
> Fix For: Shamim D
>
>
> CollectionSheetReportCachingTask is a batch job/task that is no longer
> required.
> This task (mingle card 2681) is to
> 1) remove this job from task.xml (so that it can't run anymore
> 2) identify all the code that can be removed (this may run into a previously
> commented out task CollectionSheetTask)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
