[ 
http://mifosforge.jira.com/browse/MIFOS-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58037#action_58037
 ] 

Adam Monsen edited comment on MIFOS-2888 at 6/1/10 10:20 AM:
-------------------------------------------------------------

Assigning to Buddy.

{code}
[09:52] < kakella> meonkeys: hey buddy... i have a small doubt regarding 
Mifos-2888..
[09:53] <@meonkeys> kakella: sure buddy! what's up?
[09:53] < kakella> meaonkeys: thts the link... 
                   http://mifosforge.jira.com/browse/MIFOS-2888
[09:54] < kakella> meonkeys: i just found today tht the MifosReport.rptLibrary 
has 
                   the same settings as those in the maindatabase.properties 
already
[09:54] <@meonkeys> kakella: yes, that was done in MIFOS-2840
[09:55] <@meonkeys> kakella: but this issue covers the problem with reports 
using 
                    the *JDBC* data source
[09:56] < kakella> ok.. so as part of this card... shud we want to parameterize 
                   these values and during build/install time substitute them 
with 
                   those in maindatabase.properties ?
[09:56] < kakella> meonkeys:actually... i noticed the db user name, password, 
and 
                   databse details to match
[09:57] <@meonkeys> kakella: I think we need code for runtime.., the idea would 
be 
                    that the reports using the JDBC data source would use 
whatever 
                    is in mainDatabase.properties
[09:57] < kakella> with those in maindatabase.properties
[09:57] <@meonkeys> rather, mainDatabase.properties + local.properties
[09:57] <@meonkeys> right, they match because of MIFOS-2840 ... that was the 
quick 
                    fix
[09:57] < kakella> meonkeys: ok got it... which means at runtime the jdbc 
settings 
                   inside the rptlibrary file shudn't be used
[09:57] <@meonkeys> right
[09:58] < kakella> and those from maindatbase + local props shud be used
[09:58] <@meonkeys> yes.
[09:58] <@meonkeys> however,
[09:58] < kakella> ok...
[09:58] <@meonkeys> another possibility is to *not* ship BIRT reports that use 
a 
                    JDBC data source
[09:58] <@meonkeys> I think there is currently only one
[09:59]  * meonkeys takes a look...
[10:00] < kakella> isn't tht one BIRT report being used in Mifos currently ?
[10:02] < kakella> meonkeys: anyways i'll first look into the first option of 
                   avoiding that one report from consuming the JDBC details 
from the 
                   rptlib file and instead use the props file...
[10:03] <@meonkeys> kakella: ok, sounds good. There should be code to re-use to 
                    fetch db connection details
[10:03] <@meonkeys> StandardTestingService, I think
[10:03] < kakella> meonkeys: got it buddy.. i'll look into tht..
[10:03] <@meonkeys> where the settings come from is abstracted.
[10:03] < kakella> meonkeys: thnk you
[10:03] <@meonkeys> ok!
[10:03] <@meonkeys> np.
{code}

      was (Author: meonkeys):
    Assigning to Buddy.

{code}
[09:52] < kakella> meonkeys: hey buddy... i have a small doubt regarding 
Mifos-2888..
[09:53] <@meonkeys> kakella: sure buddy! what's up?
[09:53] < kakella> meaonkeys: thts the link... 
http://mifosforge.jira.com/browse/MIFOS-2888
[09:54] < kakella> meonkeys: i just found today tht the MifosReport.rptLibrary 
has the same settings as 
                   those in the maindatabase.properties already
[09:54] <@meonkeys> kakella: yes, that was done in MIFOS-2840
[09:55] <@meonkeys> kakella: but this issue covers the problem with reports 
using the *JDBC* data source
[09:56] < kakella> ok.. so as part of this card... shud we want to parameterize 
these values and during 
                   build/install time substitute them with those in 
maindatabase.properties ?
[09:56] < kakella> meonkeys:actually... i noticed the db user name, password, 
and databse details to 
                   match
[09:57] <@meonkeys> kakella: I think we need code for runtime.., the idea would 
be that the reports 
                    using the JDBC data source would use whatever is in 
mainDatabase.properties
[09:57] < kakella> with those in maindatabase.properties
[09:57] <@meonkeys> rather, mainDatabase.properties + local.properties
[09:57] <@meonkeys> right, they match because of MIFOS-2840 ... that was the 
quick fix
[09:57] < kakella> meonkeys: ok got it... which means at runtime the jdbc 
settings inside the rptlibrary 
                   file shudn't be used
[09:57] <@meonkeys> right
[09:58] < kakella> and those from maindatbase + local props shud be used
[09:58] <@meonkeys> yes.
[09:58] <@meonkeys> however,
[09:58] < kakella> ok...
[09:58] <@meonkeys> another possibility is to *not* ship BIRT reports that use 
a JDBC data source
[09:58] <@meonkeys> I think there is currently only one
[09:59]  * meonkeys takes a look...
[10:00] < kakella> isn't tht one BIRT report being used in Mifos currently ?
[10:02] < kakella> meonkeys: anyways i'll first look into the first option of 
avoiding that one report 
                   from consuming the JDBC details from the rptlib file and 
instead use the props file...
[10:03] <@meonkeys> kakella: ok, sounds good. There should be code to re-use to 
fetch db connection 
                    details
[10:03] <@meonkeys> StandardTestingService, I think
[10:03] < kakella> meonkeys: got it buddy.. i'll look into tht..
[10:03] <@meonkeys> where the settings come from is abstracted.
[10:03] < kakella> meonkeys: thnk you
[10:03] <@meonkeys> ok!
[10:03] <@meonkeys> np.
{code}
  
> MifosReport.rptlibrary should use the same db settings as 
> mainDatabase.properties
> ---------------------------------------------------------------------------------
>
>                 Key: MIFOS-2888
>                 URL: http://mifosforge.jira.com/browse/MIFOS-2888
>             Project: mifos
>          Issue Type: Improvement
>          Components: Reports Module
>    Affects Versions: Release 1.5
>            Reporter: Adam Monsen
>            Assignee: Kalyan Akella
>            Priority: Major
>             Fix For: Release 1.5.1, Shamim D
>
>
> This is different than MIFOS-2840.
> As a short-term/partial fix for MIFOS-2840, make settings in 
> MifosReport.rptlibrary match those in mainDatabase.properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------

_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to