Resolving MIFOS-3859 exposed a bug where typeMismatch.* error messages do not 
display correctly
-----------------------------------------------------------------------------------------------

                 Key: MIFOS-4112
                 URL: http://mifosforge.jira.com/browse/MIFOS-4112
             Project: mifos
          Issue Type: Bug
          Components: Loan Account
            Reporter: jasmine sandhu
         Attachments: typeMismatchError_after3859.png, 
typeMismatchErrorOnCI_oldCode.png

In fixing: http://mifosforge.jira.com/browse/MIFOS-3859

the error messages displayed when the defineLoanProducts.flt form is 
incorrectly filled are validated by LoanProductFormBeanValidator.java. This 
class constructs the keys for the messages based on the constraint violation, 
so if the field is null, it constructs a message as:
NotNull.loanProduct.*

This message is then read from messages.properties. The messages of the form: 
typeMismatch.loanProduct.* are not being displayed correctly after this 
parameterization. 

In the previous version, they were also not being displayed, but the error was 
nicer in that it displayed:
Invalid data

Now, with the update, the error reads the string from the key but does not 
replace the parameter correctly. So it shows up as:
Please Specify the valid Start Range Loan Amount for by last loan at row 
loanAmountByLastLoanAmount[0].lower

but it should show up as follows if the error occurred on row 1:
Please Specify the valid Start Range Loan Amount for by last loan at row 1.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to