[
http://mifosforge.jira.com/browse/MIFOS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jasmine sandhu updated MIFOS-4112:
----------------------------------
Description:
In fixing: http://mifosforge.jira.com/browse/MIFOS-3859
the error messages displayed when the defineLoanProducts.flt form is
incorrectly filled are validated by LoanProductFormBeanValidator.java. This
class constructs the keys for the messages based on the constraint violation,
so if the field is null, it constructs a message as:
NotNull.loanProduct.*
This message is then read from messages.properties. The messages of the form:
typeMismatch.loanProduct.* are not being displayed correctly after this
parameterization.
As an example, if I enter a string for the first entry in the Last Loan Amount
table, it should trigger a typeMismatch error (see attached images).
In the previous version, it appears the typeMismatch.* key was not being read,
but the error was nicer in that it displayed:
Invalid data
Now, with the update, the error reads the string from the key but does not
replace the parameter correctly. So it shows up as:
Please Specify the valid Start Range Loan Amount for by last loan at row
loanAmountByLastLoanAmount[0].lower
but it should show up as follows if the error occurred on row 1:
Please Specify the valid Start Range Loan Amount for by last loan at row 1.
The commit for Mifos-3859 is: 7d543c9621afadd7754e72b83401678b0bf410ca
was:
In fixing: http://mifosforge.jira.com/browse/MIFOS-3859
the error messages displayed when the defineLoanProducts.flt form is
incorrectly filled are validated by LoanProductFormBeanValidator.java. This
class constructs the keys for the messages based on the constraint violation,
so if the field is null, it constructs a message as:
NotNull.loanProduct.*
This message is then read from messages.properties. The messages of the form:
typeMismatch.loanProduct.* are not being displayed correctly after this
parameterization.
As an example, if I enter a string for the first entry in the Last Loan Amount
table, it should trigger a typeMismatch error (see attached images).
In the previous version, it appears the typeMismatch.* key was not being read,
but the error was nicer in that it displayed:
Invalid data
Now, with the update, the error reads the string from the key but does not
replace the parameter correctly. So it shows up as:
Please Specify the valid Start Range Loan Amount for by last loan at row
loanAmountByLastLoanAmount[0].lower
but it should show up as follows if the error occurred on row 1:
Please Specify the valid Start Range Loan Amount for by last loan at row 1.
> Resolving MIFOS-3859 exposed a bug where typeMismatch.* error messages do not
> display correctly
> -----------------------------------------------------------------------------------------------
>
> Key: MIFOS-4112
> URL: http://mifosforge.jira.com/browse/MIFOS-4112
> Project: mifos
> Issue Type: Bug
> Components: Loan Account
> Reporter: jasmine sandhu
> Assignee: jasmine sandhu
> Attachments: typeMismatchError_after3859.png,
> typeMismatchError_after3859.png, typeMismatchErrorOnCI_oldCode.png,
> typeMismatchErrorOnCI_oldCode.png
>
>
> In fixing: http://mifosforge.jira.com/browse/MIFOS-3859
> the error messages displayed when the defineLoanProducts.flt form is
> incorrectly filled are validated by LoanProductFormBeanValidator.java. This
> class constructs the keys for the messages based on the constraint violation,
> so if the field is null, it constructs a message as:
> NotNull.loanProduct.*
> This message is then read from messages.properties. The messages of the form:
> typeMismatch.loanProduct.* are not being displayed correctly after this
> parameterization.
> As an example, if I enter a string for the first entry in the Last Loan
> Amount table, it should trigger a typeMismatch error (see attached images).
> In the previous version, it appears the typeMismatch.* key was not being
> read, but the error was nicer in that it displayed:
> Invalid data
> Now, with the update, the error reads the string from the key but does not
> replace the parameter correctly. So it shows up as:
> Please Specify the valid Start Range Loan Amount for by last loan at row
> loanAmountByLastLoanAmount[0].lower
> but it should show up as follows if the error occurred on row 1:
> Please Specify the valid Start Range Loan Amount for by last loan at row 1.
> The commit for Mifos-3859 is: 7d543c9621afadd7754e72b83401678b0bf410ca
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
