improve cashflow strings including months & years
-------------------------------------------------

                 Key: MIFOS-4302
                 URL: http://mifosforge.jira.com/browse/MIFOS-4302
             Project: mifos
          Issue Type: Improvement
          Components: Internationalization, Localization
            Reporter: Adam Monsen


Messages like {{CashFlowForm.monthlyCashFlows.expense}} are untranslatable. Fix.

More information:

{noformat}
-------- Original Message --------
Subject:        Re: i18n help: cashflow_messages.properties
Date:   Wed, 27 Oct 2010 23:21:07 -0500
From:   Vinod C John <[email protected]>
To:     Adam Monsen <[email protected]>

Hi Adam,

As you already found {0} and {1} are placeholders for month and year
respectively. The syntax documented
in 
http://download.oracle.com/javase/1.4.2/docs/api/java/text/MessageFormat.html,
being special characters, do not need translation in properties file.
But in the code, when we pass the values for month and year to these
message parameters, we have to pass the internationalized
value derived from Joda, like you pointed out in one of the previous
mails and I think we are passing only English values for months from
code as of now.

A JIRA ticket is a good idea as anyone can pick this up. I am lost in
some Pawdep loan calculations, will be revisiting cashflow module in a
couple of weeks and verify this. If this is a priority, let me know, I
will fix it right away.

regards
vinod


On Wed, Oct 27, 2010 at 10:25 PM, Adam Monsen wrote:

    Hi Vinod, will you reply to my email, below?

    I'd like to add a 3rd option, one in which I'd actually prefer:

    3. file the issue(s) in JIRA

    And I'll ask our i18n champions (Stanley Kwok and Jasmine Sandhu) to
    work on them.

    ---------- Forwarded message ----------
    From: Adam Monsen
    Date: Wed, Oct 6, 2010 at 1:10 PM
    Subject: i18n help: cashflow_messages.properties
    To: Vinod C John

    Hi Vinod,

    I think translators might get a little confused by these messages.
    What are {0} and {1}?

    CashFlowForm.monthlyCashFlows.expense=Please specify expense for {0} {1}.
    CashFlowForm.monthlyCashFlows.revenue=Please specify revenue for {0} {1}.
    CashFlowForm.monthlyCashFlows.notes=Notes should be between 1 to 300 
characters for {0} {1}.

    Will you either:
    1. make them more clear/translatable
    2. document these strings

    If you choose the 2nd option, a comment above each should be fine for
    now; eventually we'll want to get these in the Translatewiki.net
    format (they store them in an L10n file using the fake "_qqq" locale).

    Ah, I just took a look at 43c0a20953 ... looks like {0} and {1} are
    month and year (at least for the 1st two messages), yes?

    Anyway, just wanted to make sure our code is translatable.

    -Adam
{noformat}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly 
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus 
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to