[
http://mifosforge.jira.com/browse/MIFOS-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=65279#comment-65279
]
Mifos Hudson Jira Plugin User commented on MIFOS-4657:
------------------------------------------------------
Integrated in !http://ci.mifos.org/hudson/images/16x16/red.png!
[head-master-commit #4|http://ci.mifos.org/hudson/job/head-master-commit/4/]
MIFOS-4657: refactor interest calculation for loans for flat and declining
balance.
MIFOS-4657: interest calculation for loans
MIFOS-4657: unit tests around loan interest calculation implementations
MIFOS-4657: create util for money and unit tests
MIFOS-4657: create util for money and unit tests
MIFOS-4657: declining balance with interest recalculation should return null
interest.
MIFOS-4657: declining balance with interest recalculation should return null
interest.
MIFOS-4657: remove unused loan interest calculation code
MIFOS-4657: Refactor EMIInstallment creation
MIFOS-4657: refactor principal and interest calculation for each installment
MIFOS-4657: refactor principal and interest calculation for each installment
MIFOS-4657: refactor fee calculation and fee installment
MIFOS-4657: refactor loan schedule creation from installment details and
rawAmount (total fees and interest for loan schedule) calculation
MIFOS-4657: add comment around likely incorrect failing integration test for
removing loan disbursal fees
Keith Woodlock :
[beeac8b3f4030b6c991846cc24aa5bf3b6f6c143|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=beeac8b3f4030b6c991846cc24aa5bf3b6f6c143]
Files :
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceLoanInterestCalculator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactoryImpl.java
*
appdomain/src/main/java/org/mifos/application/servicefacade/LoanAccountServiceFacadeWebTier.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculationDetails.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDurationInAccountingYearsCalculator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/IndividualLoanScheduleFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDecliningInterestAnnualPeriodCalculatorForMonthlyRecurrence.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDurationInAccountingYearsCalculatorFactoryForWeeklyRecurrence.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanScheduleFactoryTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanScheduleFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/applicationservice/IndividualLoanAssembler.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceWithEqualPrincipalInstallmentsLoanInterestCalculator.java
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDecliningInterestAnnualPeriodCalculatorForWeeklyRecurrence.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanScheduleDetail.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/FlatLoanInterestCalculator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDurationInAccountingYearsCalculatorFactoryForMonthlyRecurrence.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDurationInAccountingYearsCalculatorFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDecliningInterestAnnualPeriodCalculatorFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanDecliningInterestAnnualPeriodCalculator.java
Keith Woodlock :
[481f83b1578d6e898290c037e8e3a6f9fdf80031|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=481f83b1578d6e898290c037e8e3a6f9fdf80031]
Files :
*
appdomain/src/main/resources/org/mifos/accounts/productdefinition/business/PrdOfferingBO.hbm.xml
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceWithEqualPrincipalInstallmentsLoanInterestCalculator.java
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
*
application/src/main/java/org/mifos/accounts/loan/struts/action/LoanAccountAction.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/IndividualLoanScheduleFactory.java
Keith Woodlock :
[155d782036a00915fac740de0091bcdb333a7c00|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=155d782036a00915fac740de0091bcdb333a7c00]
Files :
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceWithEqualPrincipalInstallmentsLoanInterestCalculatorTest.java
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanDurationInAccountingYearsMonthlyCalculatorTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/IndividualLoanScheduleFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactoryImpl.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/FlatLoanInterestCalculatorTest.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanDurationInAccountingYearsWeeklyCalculatorTest.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceLoanInterestCalculatorTest.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactoryTest.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculationDetailsBuilder.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanDurationInAccountingYearsCalculatorFactoryTest.java
Keith Woodlock :
[12b5f7316ea8131c3153d52b54dce79eea96ff5a|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=12b5f7316ea8131c3153d52b54dce79eea96ff5a]
Files :
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceLoanInterestCalculatorTest.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceWithEqualPrincipalInstallmentsLoanInterestCalculatorTest.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculationDetailsBuilder.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/FlatLoanInterestCalculatorTest.java
Keith Woodlock :
[2e44ef4885e3980f1d09e3d409e063340e2037df|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=2e44ef4885e3980f1d09e3d409e063340e2037df]
Files :
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/TestMoneyUtil.java
Keith Woodlock :
[3c709074e391ddfdad30968db0b4697b5734e2d2|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=3c709074e391ddfdad30968db0b4697b5734e2d2]
Files :
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/ViewOriginalLoanScheduleTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactoryImpl.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactoryTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/NullLoanInterestCalculator.java
Keith Woodlock :
[9fdc85e1a43810dc3e4800766f13f2cab50eac43|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=9fdc85e1a43810dc3e4800766f13f2cab50eac43]
Files :
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactoryImpl.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/NullLoanInterestCalculator.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/LoanInterestCalculatorFactoryTest.java
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/ViewOriginalLoanScheduleTest.java
Keith Woodlock :
[2f3ba86a6d8d19a93f0226e6c0341dbc29097cbc|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=2f3ba86a6d8d19a93f0226e6c0341dbc29097cbc]
Files :
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
Keith Woodlock :
[1c9e4108ce7d3df30de1ba7dc78fb173a925ff96|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=1c9e4108ce7d3df30de1ba7dc78fb173a925ff96]
Files :
*
appdomain/src/main/java/org/mifos/application/servicefacade/LoanAccountServiceFacadeWebTier.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGeneratorFactory.java
*
application/src/test/java/org/mifos/accounts/loan/business/LoanCalculationIntegrationTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGeneratorFactoryImpl.java
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanUseageDetailImpl.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceEqualInstallmentGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/FlatLoanInterestEqualInstallmentGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceEqualPrincipalEqualInstallmentGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanUsuageDetail.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGeneratorFactoryTest.java
Keith Woodlock :
[48ec5581549c7606097ee0a9b9173c78b9f32ff2|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=48ec5581549c7606097ee0a9b9173c78b9f32ff2]
Files :
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/TestMoneyUtil.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGeneratorFactory.java
*
application/src/test/java/org/mifos/accounts/loan/business/LoanBOIntegrationTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceEqualPrincipalEqualInstallmentGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/FlatLoanInterestEqualInstallmentGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGeneratorFactoryImpl.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanUseageDetailImpl.java
*
application/src/test/java/org/mifos/accounts/loan/business/LoanCalculationIntegrationTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceEqualInstallmentGenerator.java
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/IndividualLoanScheduleFactory.java
*
appdomain/src/main/java/org/mifos/accounts/loan/util/helpers/InstallmentPrincipalAndInterest.java
*
appdomain/src/main/java/org/mifos/accounts/loan/util/helpers/EMIInstallment.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanUsuageDetail.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/EqualInstallmentGeneratorFactoryTest.java
Keith Woodlock :
[bbd63f734ca38f19f5f552ff88240a8666548e27|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=bbd63f734ca38f19f5f552ff88240a8666548e27]
Files :
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/PrincipalWithInterestGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/FlatLoanPrincipalWithInterestGenerator.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceLoanPrincipalWithInterestGeneratorTest.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceEqualPrincipalWithInterestGeneratorTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalanceEqualPrincipalWithInterestGenerator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DecliningBalancePrincipalWithInterestGenerator.java
*
appdomain/src/test/java/org/mifos/clientportfolio/newloan/domain/FlatLoanPrincipalWithInterestGeneratorTest.java
Keith Woodlock :
[9c9453f0494b5ad56235f8156a5d738ad9d7f75a|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=9c9453f0494b5ad56235f8156a5d738ad9d7f75a]
Files :
*
application/src/test/java/org/mifos/accounts/loan/business/LoanCalculationIntegrationTest.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/RateInstalmentFeeCalculator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/InstallmentFeeCalculator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanScheduleRounder.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/InstallmentFeeCalculatorFactory.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/IndividualLoanScheduleFactory.java
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
*
appdomain/src/main/java/org/mifos/accounts/loan/util/helpers/LoanConstants.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/InstallmentFeeCalculatorFactoryImpl.java
* appdomain/src/main/java/org/mifos/accounts/business/AccountBO.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/AmountInstalmentFeeCalculator.java
*
appdomain/src/main/java/org/mifos/clientportfolio/newloan/domain/DefaultLoanScheduleRounder.java
Keith Woodlock :
[b0f8d585f4029f73cb3bd8032073dc2c6c561204|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=b0f8d585f4029f73cb3bd8032073dc2c6c561204]
Files :
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
*
application/src/test/java/org/mifos/accounts/loan/business/LoanCalculationIntegrationTest.java
Keith Woodlock :
[e874dcbf739386a16001c8c4dfe8cca82b554e20|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=e874dcbf739386a16001c8c4dfe8cca82b554e20]
Files :
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
> TECHDEBT: procedural code: remove procedural code for creating LoanSchedule
> installments for loans
> --------------------------------------------------------------------------------------------------
>
> Key: MIFOS-4657
> URL: http://mifosforge.jira.com/browse/MIFOS-4657
> Project: mifos
> Issue Type: Story
> Components: Loan Account
> Affects Versions: Elsie F
> Reporter: keithwoodlock
> Assignee: keithwoodlock
> Labels: proceduralcode, techdebt
> Fix For: Release G - Iteration 1, Release G
>
>
> As part of work to spike opening balances for loans I came upon the
> 'procedural' code that is responsible for creating the loan installments. I
> refactored this code a little bit and duplicated it in loan service facade
> (also in loanBO). What needs to happen is that this procedural code is moved
> into a seperate class and this code is invoked where installments are needed
> to be created, (loan creation, redo loan, loan disbursal etc) and then remove
> the masses or procedural code from LoanBO itself.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
