[
http://mifosforge.jira.com/browse/MIFOS-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=65493#comment-65493
]
Mifos Hudson Jira Plugin User commented on MIFOS-4657:
------------------------------------------------------
Integrated in !http://ci.mifos.org/hudson/images/16x16/red.png! [head-master
#2908|http://ci.mifos.org/hudson/job/head-master/2908/]
MIFOS-4657: remove apply rounding code and installments creation code from
loanBO. remove static analysis warnings using quick fix
Keith Woodlock :
[43ebeb5e2b414e9f55367918c4371ece78dfdf9b|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=43ebeb5e2b414e9f55367918c4371ece78dfdf9b]
Files :
*
abstract-domain/src/main/java/org/mifos/application/master/business/LookUpValueEntity.java
* appdomain/src/main/java/org/mifos/customers/business/CustomerBO.java
* application/src/test/java/org/mifos/framework/formulaic/ValidatorsTest.java
*
appdomain/src/main/java/org/mifos/reports/branchreport/BranchReportStaffingLevelSummaryBO.java
*
application/src/main/java/org/mifos/accounts/savings/struts/tag/SavingsOverDueDepositsTag.java
*
reporting/src/main/java/org/mifos/reports/business/validator/JdbcBranchCashConfirmationReportParamValidator.java
*
reporting/src/main/java/org/mifos/reports/business/service/BirtCollectionSheetReportService.java
* appdomain/src/main/java/org/mifos/customers/client/business/LoanCounter.java
* appdomain/src/main/java/org/mifos/accounts/api/StandardAccountService.java
*
appdomain/src/main/java/org/mifos/framework/hibernate/helper/QueryResultDTOImpl.java
*
application/src/main/java/org/mifos/framework/persistence/DatabaseInitFilter.java
*
application/src/main/java/org/mifos/accounts/loan/struts/actionforms/LoanAccountActionForm.java
*
reporting/src/main/java/org/mifos/framework/components/logger/ServiceActivityLogger.java
* appdomain/src/main/java/org/mifos/security/util/ActivityChangeEvent.java
*
reporting/src/main/java/org/mifos/framework/components/batchjobs/helpers/BranchReportSqlDataAggregator.java
*
appdomain/src/main/java/org/mifos/application/collectionsheet/persistence/CollectionSheetDaoHibernate.java
*
appdomain/src/main/java/org/mifos/application/meeting/util/helpers/WeekDayUserType.java
*
appdomain/src/main/java/org/mifos/application/master/util/helpers/PaymentTypes.java
*
application/src/test/java/org/mifos/accounts/loan/struts/action/LoanAccountActionStrutsTest.java
*
abstract-domain/src/main/java/org/mifos/application/util/helpers/YesNoFlag.java
*
serviceInterfaces/src/main/java/org/mifos/clientportfolio/newloan/domain/LoanProductId.java
*
appdomain/src/main/java/org/mifos/accounts/loan/struts/action/validate/ProductMixValidator.java
*
appdomain/src/main/java/org/mifos/config/persistence/ApplicationConfigurationDaoHibernate.java
*
appdomain/src/main/java/org/mifos/application/holiday/util/helpers/RepaymentRuleUserType.java
* appdomain/src/main/java/org/mifos/accounts/util/helpers/AccountState.java
*
application/src/test/java/org/mifos/framework/components/batchjobs/helpers/BranchReportLoanArrearsAgingHelperIntegrationTest.java
* application/src/main/java/org/mifos/framework/struts/plugin/ConstPlugin.java
*
reporting/src/main/java/org/mifos/reports/business/service/BranchReportService.java
* application/src/main/java/org/mifos/framework/struts/plugin/EnumPlugin.java
*
appdomain/src/main/java/org/mifos/customers/group/business/GroupPerformanceHistoryUpdater.java
*
appdomain/src/main/java/org/mifos/reports/cashconfirmationreport/BranchCashConfirmationReportBO.java
* application/src/main/java/org/mifos/application/admin/system/SystemInfo.java
*
abstract-domain/src/main/java/org/mifos/application/meeting/util/helpers/WeekDay.java
*
appdomain/src/main/java/org/mifos/accounts/loan/business/OriginalLoanFeeScheduleEntity.java
* application/src/test/java/org/mifos/security/util/LoginFilterStrutsTest.java
*
appdomain/src/main/java/org/mifos/customers/client/business/ClientPerformanceHistoryEntity.java
*
application/src/test/java/org/mifos/framework/hibernate/helper/AuditTransactionForTests.java
*
serviceInterfaces/src/main/java/org/mifos/clientportfolio/newloan/domain/ClientId.java
*
appdomain/src/main/java/org/mifos/accounts/business/AccountActionDateEntity.java
*
reporting/src/main/java/org/mifos/reports/business/JdbcBranchCashConfirmationReportParameterForm.java
*
appdomain/src/main/java/org/mifos/schedule/internal/AbstractScheduledEvent.java
* appdomain/src/main/java/org/mifos/security/util/OfficeChangeEvent.java
*
reporting/src/main/java/org/mifos/reports/branchreport/helper/BranchReportClientSummaryBatchBOExtractor.java
* application/src/test/java/org/mifos/reports/business/MockFormFile.java
*
appdomain/src/main/java/org/mifos/accounts/productdefinition/business/LoanOfferingBO.java
*
appdomain/src/main/java/org/mifos/framework/util/helpers/MifosSqlDateConverter.java
*
appdomain/src/main/java/org/mifos/framework/util/helpers/MifosStringToJavaUtilDateConverter.java
*
application/src/test/java/org/mifos/customers/office/business/OfficeTemplateImpl.java
*
reporting/src/main/java/org/mifos/reports/business/CollectionSheetReportParameterForm.java
* application/src/test/java/org/mifos/ui/webflow/CreateSavingsAccountTest.java
* appdomain/src/main/java/org/mifos/accounts/business/AccountStateEntity.java
*
application/src/test/java/org/mifos/customers/personnel/business/PersonnelTemplateImpl.java
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/core/DatasetVersionTest.java
* appdomain/src/main/java/org/mifos/accounts/fees/util/helpers/FeeFormula.java
* application/src/test/java/org/mifos/customers/CustomerTemplateImpl.java
* appdomain/src/main/java/org/mifos/accounts/business/AccountBO.java
*
application/src/main/java/org/mifos/framework/struts/plugin/InitializerPlugin.java
*
appdomain/src/main/java/org/mifos/application/servicefacade/CollectionSheetDtoTranslatorImpl.java
*
appdomain/src/main/java/org/mifos/customers/group/business/GroupLoanCounter.java
*
appdomain/src/main/java/org/mifos/accounts/savings/persistence/SavingsDaoHibernate.java
* db/src/main/java/org/mifos/db/upgrade/ResourceOpener.java
*
appdomain/src/main/java/org/mifos/customers/personnel/persistence/LegacyPersonnelDao.java
*
appdomain/src/main/java/org/mifos/customers/persistence/CustomerDaoHibernate.java
*
application/src/test/java/org/mifos/accounts/financial/business/service/activity/accountingentry/InterestPostingAccountingEntryTest.java
*
appdomain/src/main/java/org/mifos/application/servicefacade/LoanAccountServiceFacadeWebTier.java
*
appdomain/src/main/java/org/mifos/application/holiday/persistence/HolidayServiceFacadeWebTier.java
* appdomain/src/main/java/org/mifos/accounts/loan/business/LoanBO.java
* application/src/test/java/org/mifos/customers/center/CenterTemplateImpl.java
*
appdomain/src/main/java/org/mifos/accounts/fees/persistence/FeeDaoHibernate.java
*
appdomain/src/main/java/org/mifos/accounts/loan/schedule/domain/Installment.java
*
appdomain/src/main/java/org/mifos/schedule/internal/HolidayAndWorkingDaysAndMoratoriaScheduledDateGeneration.java
* application/src/test/java/org/mifos/customers/group/GroupTemplateImpl.java
*
application/src/main/java/org/mifos/framework/components/batchjobs/helpers/ApplyHolidayChangesHelper.java
*
serviceInterfaces/src/main/java/org/mifos/dto/screen/TransactionHistoryDto.java
*
reporting/src/main/java/org/mifos/reports/business/validator/DetailedAgingPortfolioReportParamValidator.java
* reporting/src/main/java/org/mifos/framework/business/service/ServiceProxy.java
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionEntity.java
* appdomain/src/main/java/org/mifos/security/util/RoleChangeEvent.java
*
application/src/test/java/org/mifos/framework/components/batchjobs/helpers/BranchReportStaffingLevelSummaryHelperIntegrationTest.java
*
userInterface/src/main/java/org/mifos/ui/core/controller/AccountDetailFormBean.java
*
appdomain/src/main/java/org/mifos/accounts/business/AccountFeesActionDetailEntity.java
*
reporting/src/main/java/org/mifos/reports/business/validator/BranchCashConfirmationReportParamValidator.java
*
appdomain/src/main/java/org/mifos/application/master/business/CustomFieldType.java
* appdomain/src/main/java/org/mifos/framework/util/TransformerUtils.java
*
appdomain/src/main/java/org/mifos/accounts/loan/struts/uihelpers/PaymentDataHtmlBean.java
*
appdomain/src/main/java/org/mifos/reports/cashconfirmationreport/BranchCashConfirmationInfoBO.java
*
application/src/test/java/org/mifos/framework/util/helpers/MockObjectHelpers.java
*
userInterface/src/main/java/org/mifos/ui/core/controller/RedirectionController.java
*
appdomain/src/main/java/org/mifos/customers/group/business/GroupPerformanceHistoryEntity.java
*
reporting/src/main/java/org/mifos/reports/branchreport/persistence/BranchReportPersistence.java
* appdomain/src/main/java/org/mifos/security/authorization/HierarchyManager.java
*
application/src/main/java/org/mifos/servlet/filters/MifosResponseHeaderFilter.java
*
application/src/main/java/org/mifos/framework/components/tabletag/TableTagErrorHandler.java
*
application/src/test/java/org/mifos/reports/branchreport/persistence/BranchReportPersistenceIntegrationTest.java
*
reporting/src/main/java/org/mifos/reports/business/BranchReportParameterForm.java
* appdomain/src/main/java/org/mifos/accounts/financial/business/COABO.java
*
reporting/src/main/java/org/mifos/reports/business/validator/SqlCollectionSheetReportParamValidator.java
*
appdomain/src/main/java/org/mifos/application/meeting/util/helpers/RankOfDayUserType.java
* application/src/main/java/org/mifos/security/util/LoginFilter.java
*
appdomain/src/main/java/org/mifos/framework/util/helpers/MifosDoubleConverter.java
*
reporting/src/main/java/org/mifos/reports/business/validator/CollectionSheetReportParamValidator.java
*
cashflow/src/main/java/org/mifos/platform/cashflow/service/CashFlowServiceImpl.java
*
appdomain/src/main/java/org/mifos/application/servicefacade/CollectionSheetServiceFacadeWebTier.java
*
reporting/src/main/java/org/mifos/reports/business/DetailedAgingPortfolioReportParameters.java
* appdomain/src/main/java/org/mifos/framework/hibernate/IntEnumUserType.java
*
appdomain/src/main/java/org/mifos/accounts/loan/business/OriginalLoanScheduleEntity.java
*
application/src/main/java/org/mifos/application/servicefacade/LoanServiceFacadeWebTier.java
*
application/src/main/java/org/mifos/accounts/loan/struts/action/MultipleLoanAccountsCreationAction.java
* appdomain/src/main/java/org/mifos/framework/util/helpers/ChapterNum.java
*
application/src/test/java/org/mifos/application/meeting/MeetingTemplateImpl.java
* appdomain/src/main/java/org/mifos/schedule/internal/DailyScheduledEvent.java
*
organization/src/main/java/org/mifos/application/holiday/business/HolidayBO.java
*
application/src/main/java/org/mifos/accounts/loan/struts/actionforms/MultipleLoanAccountsCreationActionForm.java
* organization/src/main/java/org/mifos/customers/office/business/OfficeBO.java
* appdomain/src/main/java/org/mifos/framework/formulaic/BaseValidator.java
*
appdomain/src/main/java/org/mifos/application/master/business/BusinessActivityEntity.java
*
appdomain/src/main/java/org/mifos/accounts/loan/persistance/LoanDaoHibernate.java
*
application/src/test/java/org/mifos/application/admin/system/MockDatabaseMetaData.java
*
application/src/test/java/org/mifos/accounts/financial/business/service/activity/accountingentry/BaseAccountingEntryTestCase.java
*
application/src/test/java/org/mifos/accounts/util/helper/AccountStateIntegrationTest.java
*
application/src/main/java/org/mifos/accounts/loan/struts/action/LoanAccountAction.java
*
appdomain/src/main/java/org/mifos/accounts/fund/persistence/FundDaoHibernate.java
*
appdomain/src/main/java/org/mifos/customers/persistence/CustomerPersistence.java
*
reporting/src/main/java/org/mifos/framework/components/batchjobs/helpers/BranchReportPersistenceDataAggregator.java
> TECHDEBT: procedural code: remove procedural code for creating LoanSchedule
> installments for loans
> --------------------------------------------------------------------------------------------------
>
> Key: MIFOS-4657
> URL: http://mifosforge.jira.com/browse/MIFOS-4657
> Project: mifos
> Issue Type: Story
> Components: Loan Account
> Affects Versions: Elsie F
> Reporter: keithwoodlock
> Assignee: keithwoodlock
> Labels: proceduralcode, techdebt
> Fix For: Release G - Iteration 1, Release G
>
>
> As part of work to spike opening balances for loans I came upon the
> 'procedural' code that is responsible for creating the loan installments. I
> refactored this code a little bit and duplicated it in loan service facade
> (also in loanBO). What needs to happen is that this procedural code is moved
> into a seperate class and this code is invoked where installments are needed
> to be created, (loan creation, redo loan, loan disbursal etc) and then remove
> the masses or procedural code from LoanBO itself.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
