[
https://issues.apache.org/jira/browse/MIME4J-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987958#comment-17987958
]
Tim Allison commented on MIME4J-332:
------------------------------------
And turning it off breaks these tests:
{noformat}
Failures:
[ERROR] ContentDispositionFieldTest.testFileNameWithMultipleSections:154
expected:<first part [of long filename.txt]> but was:<first part []>
[ERROR] ContentDispositionFieldTest.testNonAsciiFilename:123
expected:<...-Sheet - XXX A 2 40 [201 - Fasader nordøst og nordvest.dwg]> but
was:<...-Sheet - XXX A 2 40 [=?UTF-8?Q?]>
[ERROR] LenientContentDispositionFieldTest.testBadEncodingFilename:237
expected:<4%P001!.DOC[]> but was:<4%P001!.DOC[4%P001!.DOC]>
[ERROR] LenientContentDispositionFieldTest.testGetFilenameMultipartUtf8:141
expected:<Ростелеко[м.xlsx]> but was:<Ростелеко[]>
[ERROR] LenientContentDispositionFieldTest.testMultipartFileName:214
expected:<...oooooooooooooooooooo[oooooooooooooooooooooooooooooooooooooong_fiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiileeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee.txt]>
but was:<...oooooooooooooooooooo[]>
[ERROR] LenientContentDispositionFieldTest.testNonAsciiFilename:226
expected:<...-Sheet - XXX A 2 40 [201 - Fasader nordøst og nordvest.dwg]> but
was:<...-Sheet - XXX A 2 40 [=?UTF-8?Q?]>
[INFO]
[ERROR] Tests run: 571, Failures: 6, Errors: 0, Skipped: 28
{noformat}
> Prevent concatenation of duplicate fields in ContentDispositionParser
> ---------------------------------------------------------------------
>
> Key: MIME4J-332
> URL: https://issues.apache.org/jira/browse/MIME4J-332
> Project: James Mime4j
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Minor
>
> Over on https://issues.apache.org/jira/browse/TIKA-4447, [[email protected]]
> reported that content disposition fields were concatenating file names if
> there were multiple file names.
> Minimal reproducer in {{master}} in {{{}ContentDispositionTest{}}}:
> {code:java}
> @Test
> public void testDuplicateFields() throws ParseException {
> String s = "attachment; filename=\"bar1.rtf\"; filename=\"bar2.rtf\";
> filename=\"bar3.rtf\"";
> ContentDispositionParser parser = new ContentDispositionParser(new
> StringReader(s));
> parser.parse();
> assertEquals("bar1.rtf", parser.getParameters().get("filename"));
> }
>
> {code}
> With result:
> {noformat}
> org.junit.ComparisonFailure:
> Expected :bar1.rtf
> Actual :bar1.rtfbar2.rtfbar3.rtf
> {noformat}
> I'm not sure whether the "correct" behavior is to pick the first or the last.
> It looks like Thunderbird picks the first.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
