[
https://issues.apache.org/jira/browse/MIME4J-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987963#comment-17987963
]
Gregory Lepore commented on MIME4J-332:
---------------------------------------
I can't follow the specific code, "not an issue" in what way? It seems picking
either filename is preferable to causing an issue with selecting both.
Possibly relevant Thunderbird Issue describing their solution:
https://bugzilla.mozilla.org/show_bug.cgi?id=588781
> Prevent concatenation of duplicate fields in ContentDispositionParser
> ---------------------------------------------------------------------
>
> Key: MIME4J-332
> URL: https://issues.apache.org/jira/browse/MIME4J-332
> Project: James Mime4j
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Minor
>
> Over on https://issues.apache.org/jira/browse/TIKA-4447, [~g...@rhobard.com]
> reported that content disposition fields were concatenating file names if
> there were multiple file names.
> Minimal reproducer in {{master}} in {{{}ContentDispositionTest{}}}:
> {code:java}
> @Test
> public void testDuplicateFields() throws ParseException {
> String s = "attachment; filename=\"bar1.rtf\"; filename=\"bar2.rtf\";
> filename=\"bar3.rtf\"";
> ContentDispositionParser parser = new ContentDispositionParser(new
> StringReader(s));
> parser.parse();
> assertEquals("bar1.rtf", parser.getParameters().get("filename"));
> }
>
> {code}
> With result:
> {noformat}
> org.junit.ComparisonFailure:
> Expected :bar1.rtf
> Actual :bar1.rtfbar2.rtfbar3.rtf
> {noformat}
> I'm not sure whether the "correct" behavior is to pick the first or the last.
> It looks like Thunderbird picks the first.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
