On 2/22/06, Chris Allen <[EMAIL PROTECTED]> wrote:
>
> > I suggest that you refactor your ProtocolDecoder to use
> > CumulativeProtocolDecoder first to see if that fixes the problem. Maybe
> > you're not releasing the buffers correctly?
>
> I think the thing that I forgot to do is to clean up the buf instance with
> the dispose() method.  Man I hope that's it. :-)  Thanks for reminding me
> of
> your CumulativeProtocolDecoder though, as just reviewing the code made
> this
> clear to me.


If you don't release the buffer, it doesn't go back to the pool.  This means
the buffer will be GC'd automatically once you lose its reference, so I
think this won't make any big difference.  But please let us know if any of
your changes made an improvement.

Thanks,
Trustin
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP key fingerprints:
* E167 E6AF E73A CBCE EE41  4A29 544D DE48 FE95 4E7E
* B693 628E 6047 4F8F CFA4  455E 1C62 A7DC 0255 ECA6

Reply via email to