[ http://issues.apache.org/jira/browse/DIRMINA-184?page=comments#action_12370224 ]
Srikanth Veeramachaneni commented on DIRMINA-184: ------------------------------------------------- Attached is a slight variant of the pluggable ThreadPoolFilter. It differs only slightly from the one that was already submitted in the following manner - The SessionBuffer is maintained as an attribute of the IoSession instead of in a single map. This shifts the synchronization on the IoSession instead of on the map. Not sure if I am losing any performance by doing so. But this way, the life cycle of a SessionBuffer is linked to the life cycle of the IoSession. Only one session buffer is created for each IoSession instead of the session buffer being released every time the event queue become empty. - Removed the need for 'queuedSessionBuffers' by adding a 'processingCompleted' flag. I assumed that the sole purpose of this queue was to know when a new runnable task has to be created for a session buffer. A subtle change is that I replaced the use of ConcurrentLinkedQueue with a LinkedList for the event queue, as I synchronize on the event queue both the times when the queue is accessed. > Allow ThreadPool used by ThreadPoolFilter to be pluggable > --------------------------------------------------------- > > Key: DIRMINA-184 > URL: http://issues.apache.org/jira/browse/DIRMINA-184 > Project: Directory MINA > Type: Improvement > Reporter: peter royal > Attachments: pluggable thread pool.diff > > Attached is the start of a patch to allow the ThreadPool that a > ThreadPoolFilter uses to be pluggable. Currently depends on Java5, but works > as an illustration of thoughts. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
