[
http://issues.apache.org/jira/browse/DIRMINA-184?page=comments#action_12402269
]
Trustin Lee commented on DIRMINA-184:
-------------------------------------
Peter, I have a few questions about your commit:
1)
At line 187 of LeaderFollowerThreadPool:
//TODO this should be in the filter, inits on pre-add if we have not been
init'ed
public void onPreAdd( IoFilterChain parent, String name,
IoFilter.NextFilter nextFilter )
throws Exception
{
if( leader == null )
{
init();
}
}
Do we need this method? I guess this method is not invoked by anyone.
2) If LeaderFollowerThreadPool and ThreadPoolThreadPoolFilter provides exactly
the same functionality with ThreadPoolFilter, why don't we replace it?
ThreadPoolThreadPoolFilter could become a ThreadPoolFilter which uses
LeaderFollowerThreadPool by default, and the pool implementation could be
changed if a user specifies his or her favorite pool implementation.
3) Can't we simply expose ProcessEventRunnable to users and make
ThreadPool.submit accept it instead of Object?
> Allow ThreadPool used by ThreadPoolFilter to be pluggable
> ---------------------------------------------------------
>
> Key: DIRMINA-184
> URL: http://issues.apache.org/jira/browse/DIRMINA-184
> Project: Directory MINA
> Type: Improvement
> Reporter: peter royal
> Assignee: peter royal
> Fix For: 0.9.5
> Attachments: NewThreadPoolFilter.java, pluggable thread pool.diff
>
> Attached is the start of a patch to allow the ThreadPool that a
> ThreadPoolFilter uses to be pluggable. Currently depends on Java5, but works
> as an illustration of thoughts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
