[ http://issues.apache.org/jira/browse/DIRMINA-196?page=all ]
Michael Bauroth updated DIRMINA-196:
------------------------------------
Attachment: ConnectionLimitFilter_v1.java
I attached a new version of the connection limit filter. I named it version 1
because of some open questions:
1. I think, the implementation lacks at the moment from the fact, that when I
add the filter not at the beginning of the application lifecycle, the real
number of already opened connections doesn't match the internally incremented
number of connections. What would the best way to fix it?
2. I've marked the blockConnection method protected to give users the
possibilty to override the behaviour of blocking in a more sophisticated manner
(e.g. here already mentioned time response dependency) Is this the right
(preferred) style in the Mina project?
3. Does it make sense, when I implement another method / flag, which defines,
if the blocking should happen while opening or while creation of the session? I
ask because of I could imagine, when the main application works behind a self
written load balancer, it would be better to verbose the creation of the
session too so that the balancer can try another server instead?
4. Should I write the non overriden methods too (or drop them)?
5. Should I implement some additional functionality for reconnections (e.g. how
long in seconds will a connection retry from a previous blocked connection
blocked until permission)?
That's all for the moment :)
> Connection shaper
> -----------------
>
> Key: DIRMINA-196
> URL: http://issues.apache.org/jira/browse/DIRMINA-196
> Project: Directory MINA
> Type: New Feature
> Versions: 0.9.2
> Reporter: Michael Bauroth
> Priority: Trivial
> Attachments: ConnectionLimitFilter_v1.java, ConnectionShapeFilter.java
>
> How about to add an connection shaping filter (maybe to the examples)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
