On 07/06/13 11:00, dw wrote:
>> 3) Where winbase.h defines __stdcall prototypes for these functions, 
>> keep the implementation in the library.
> You know, now that I think about it, I have to ask if leaving these 
> __stdcall implementations in the library is actually useful.  After all, 
> it's not like they ever actually call kernel32.dll (either before or 
> after my patch).
>
> In fact, why not just map them to the intrinsics?  The inlines would 
> certainly give better performance, and the downside is, well, I can't 
> think of one.  The only other alternative that might make sense is if we 
> want to re-work these to actually call kernel32.

Sorry for the delay, again... The plan sounds mostly good. My suggestions:
- Remove non-underscored (aka. __stdcall) variants from mingwex. It's
exported by kernel32.dll, so we may use it if needed (or is there some
compatibility reason not to?)
- For 32-bit version, I'd say that we should have inline versions,
probably in winbase.h, redirecting to intrins versions.

Thanks,
Jacek

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to