Hi
patch looks ok to me. Beside one nit.
Point 3 should not force none-inline version. Please expain why you think
that is required.
Kai
Am 13.07.2013 15:11 schrieb "dw" <[email protected]>:
> 1) Move these functions to intrin-impl.h:
>
> __readfsbyte, __readfsword, __readfsdword
> __writefsbyte, __writefsword, __writefsdword
> __readgsbyte, __readgsword, __readgsdword, __readgsqword
> __writegsbyte, __writegsword, __writegsdword, __writegsqword
>
> 2) Update inline asm code:
>
> *a) Change __write* so "Data" is an input. Without this, the wrong value
> gets written.*
> *b) Change __write* routines so they are NOT volatile.*
> c) Change __write* so "Data" uses "ri" constraint for
> (potentially)(slightly) better performance.
> d) Change __read* so they are not volatile.
> e) Change __read* so offset is an input param
> f) Support both att and intel asm formats for both __read* and __write*
>
> 3) Change NtCurrentTeb, GetCurrentFiber, and GetFiberData to use existing
> routines instead of inline asm.
>
> dw
>
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> _______________________________________________
> Mingw-w64-public mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
