2014-09-19 1:34 GMT+02:00 dw <[email protected]>:
> For the parts that are "working around a compiler bug":
>
> - Does it make sense to list the bug number in the comment?
I think it makes sense in general.  Only important thing should be to
mark bug-number, that it belongs to SF bug-tracker.  We might want to
change in future bug-tracker and so we would loose relation.

> - If the bug has been fixed, what about using __GNUC__ and __GNUC_MINOR__ to
> limit the code?

Well, depends on the nature of code.  If it is a general bug-fix, then
I don't see the need for __GNUC__/__GNUC_MINOR__ guarding (btw we have
in _mingw.h some helper-macros for checking easier gcc-version).
For compiler-specific bugs, it makes sense.  Only questional point
here is how we treat reviews for new-compilers, as the reason for
compiler-related bug-fixes might be resolved in future version.

> dw

Kai

------------------------------------------------------------------------------
Slashdot TV.  Video for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to