On Wed, Mar 2, 2016 at 2:10 AM, İsmailDönmez <[email protected]> wrote: > > Dongsheng Song <dongsheng.song@...> writes: > > > On Tue, Mar 1, 2016 at 8:42 PM, Ismail Donmez <ismail- > [email protected]> wrote:Hi, > > mingw-w64's current mkstemp implementation wrongly uses _O_TEMPORARY > which > > doesn't make sense. Here is a patch from openSUSE we apply to fix it: > > From: Jan Engelhardt <[email protected]> > > Date: 2015-03-31 18:57:45.887248277 +0200 > > References: https://sourceforge.net/p/mingw-w64/bugs/471/ > > When closing the file handle obtained from mkstemp(), the file > > ought _not_ to be deleted. > > > > > > Why did you make such assertion ? > > > > I can not see such statement in POSIX, Linux, FreeBSD or OpenBSD: > > > > http://pubs.opengroup.org/onlinepubs/009695399/functions/mkstemp.html > > http://man7.org/linux/man-pages/man3/mkstemp.3.html > > https://www.freebsd.org/cgi/man.cgi?query=mkstemp > > I just tested the relevant Windows function _mkstemp_s > (https://msdn.microsoft.com/en-us/library/t8ex5e91.aspx) and it does not > remove the temp file on close. > > Also tested on Linux with glibc 2.22 and it doesn't remove the temporary > file either. > > So mingw-w64's current behaviour is not compatible with any of them. IMHO > patch should be applied. >
OK, for compatible reason, I have no objections now. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
