I was looking to see if there was any more inline asm that could be removed from mingw-w64. That brought me to vsscanf (and friends). This looked to be a messy bit of code that could probably use a review.

As I started looking through it, I found what I believe to be a bunch of flaws (see https://codereview.stackexchange.com/questions/133266/turn-a-vsscanf-call-into-a-sscanf-call). I started trying to clean it up, but eventually decided that the only way to really make this 'clean' was to re-write it in pure assembly. Which I have done.

I've got a first draft attached. I don't know that this follows standard mingw-w64 coding conventions, but it follows Windows coding standards better than the existing code.

My question is: Now what?

The patch is written. I've tested it and it looks like it works. Where do we go from here?

Comments and advice are welcome. Remember to regen Makefile.in if you want to build this.

dw
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to