Haha, no - although I do work for a game company, I'd rather not say which on-list.
Am I mistaken in that the patch affects the CRT? In which case, defining _WIN32_WINNT would only be useful at the point of building mingw-w64 itself - building and maintaining our own mingw-w64 is not an option for us with our current build pipeline, as we rely on mingw-builds currently. Any change to the default would leave us in future with a toolchain unable to build for mingw-w64. Regards, Riot On 12 June 2017 at 18:46, David Grayson <[email protected]> wrote: > Riot, do you work for Riot Games? > > Anyway, in this patch, the line of code being changed is guarded by > #ifndef _WIN32_WINNT. So if you define _WIN32_WINNT yourself, this > patch will have no effect on you. (I'm assuming that the value of > _WIN32_WINNT does not affect how the MinGW libraries are compiled, and > it only affects what features are available in the header files.) > > --David > > On Mon, Jun 12, 2017 at 10:36 AM, Riot <[email protected]> wrote: > > I'd like to humbly request a hold on this. > > > > If it's not broken, why fix it? > > > > I've been happy to be able to tell our customers that our software works > on > > win XP (SP2) for a long while; and I don't see anything that's changed > that > > should require us to end that support. When we surveyed last year, > several > > percent of our users still used XP, and we don't really want to leave > them > > out in the cold without good reason. Building our own mingw just to > > configure it with a lower default support version is out of the question > > with our workflow, unfortunately. > > > > I don't see this as a constructive change, as it doesn't appear to > actually > > improve anything for anybody. Can we reconsider? > > > > > > Regards, > > Riot > > > > > > On 12 June 2017 at 18:02, Liu Hao <[email protected]> wrote: > > > >> On 2017/6/12 23:17, Martell Malone wrote: > >> > >>> In that case, > >>> I think the best course of immediate action is to bump to Windows 7 as > Kai > >>> suggested. > >>> If someone has the time to implement a configure option for changing > this > >>> default like Ruben suggest that would be a great. > >>> Here is a patch for the former. > >>> Please Review > >>> > >>> diff --git a/mingw-w64-headers/crt/_mingw.h.in > b/mingw-w64-headers/crt/_ > >>> mingw.h.in > >>> index 2742b115..03de2212 100644 > >>> --- a/mingw-w64-headers/crt/_mingw.h.in > >>> +++ b/mingw-w64-headers/crt/_mingw.h.in > >>> @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ > >>> #ifndef _WIN32_WINNT > >>> -#define _WIN32_WINNT 0x502 > >>> +#define _WIN32_WINNT 0x601 > >>> #endif > >>> #ifndef _INT128_DEFINED > >>> > >>> Upvote for this. OK for master? > >> > >> -- > >> Best regards, > >> LH_Mouse > >> > >> > >> > >> ------------------------------------------------------------ > >> ------------------ > >> Check out the vibrant tech community on one of the world's most > >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> _______________________________________________ > >> Mingw-w64-public mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > >> > > ------------------------------------------------------------ > ------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > Mingw-w64-public mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Mingw-w64-public mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
