Hi Ruslan,
On 13.07.2017 17:04, Ruslan Garipov wrote:
>
> This is the second commit in the series that adds support of Windows
> Animation Manager (WAM) into mingw-w64.
Thanks for the patch. I have a few comments.
> +/* Enumeration declarations. */
> +enum __MIDL___MIDL_itf_UIAnimation_0000_0002_0002
> +{
> + UI_ANIMATION_SCHEDULING_UNEXPECTED_FAILURE = (int) 0xc000000,
> + UI_ANIMATION_SCHEDULING_INSUFFICIENT_PRIORITY = (int) 0xc000001,
> + UI_ANIMATION_SCHEDULING_ALREADY_SCHEDULED = (int) 0xc000002,
> + UI_ANIMATION_SCHEDULING_SUCCEEDED = (int) 0xc000003,
> + UI_ANIMATION_SCHEDULING_DEFERRED = (int) 0xc000004
> +};
This should be something like:
typedef [v1_enum] enum
{
// ...
} UI_ANIMATION_SCHEDULING_RESULT;
widl will add those weird decorations for you. Same for other enums.
> +/* Interface declarations. */
> +[
> + uuid(9169896C-AC8D-4E7D-94E5-67FA4DC2F2E8),
> + helpstring("IUIAnimationManager Interface")
> +]
> +interface IUIAnimationManager : IUnknown
> +{
> + [id(0x60010000)]
I think that's the default id that's used if there is no explicit id()
attribute. Please remove those, widl will take care of that for you.
> + HRESULT __stdcall CreateAnimationVariable (
> + [in] double initialValue,
> + [out, retval] IUIAnimationVariable **variable
> + );
__stdcall is default for interface methods, so there is no need to
specify it. widl will do the right thing with those.
Thanks,
Jacek
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
