No problem, it was left forgotten there. Yes I was making clang able to host itself at MSYS2 and ran into this error on 64bit builds. If Lio says C-style cast is fine then I'm OK with that.
I'm 80% sure I've seen this in another project as well and GCC allowed it but your description is better and this patch should be committed. You can add my sign-off if you want but it's not important. ------ Original Message ------ Subject: Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h Date: Fri, 25 Aug 2017 14:23:09 +0300 (EEST) To: Mingw-w64-public From: Martin Storsjö > On Fri, 25 Aug 2017, Mateusz Mikuła wrote: > >> There was discussion if this should be done via cast or union, both >> versions were attached at some point of [1] discussion. >> >> [1] https://sourceforge.net/p/mingw-w64/mailman/message/35923114/ > > Oh, I see - sorry for missing that. > > I don't mind whichever approach gets chosen; using a union is totally > ok with me, as long as some sort of fix is committed. > > FWIW, I take it you ran into this issue in trying to build libcxx as > well? It might be good to amend your patch with my explanation - it's > not a matter about gcc vs clang (g++ also refuses to convert from > const wchar_t* to wchar_t*), but this is only an issue if the libcxx > headers get included inbetween, where the const wchar_t* prototype > comes from. > > // Martin > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Mingw-w64-public mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
