在 2019/8/26 13:35, Christian Franke 写道: >>> >>> The patch also shows how varargs *printf() wrappers could be rewritten >>> if compiler supports __builtin_va_arg_pack(). >>> >>> Thanks for any comment. >>> >> Thanks for the interesting patch, do you know what needs to be changed >> in GCC? >> > > > Possibly nothing. Works out of the box with *-w64-mingw32-gcc and -g++ > 7.4.0 from current Cygwin package. > >
Thanks for your extensive work. The patch looks mostly good. I have a couple of questions: 0) What was the purpose of the suppression of `-Wformat-nonliteral`? It seemed not added in every `v?sn?printf` function. 1) As for 'string.h', there is already an `extern "C"` block, so is it necessary to declare a new one? Everything could have been in that one which saves some lines. 2) Would you please add a wrapper for `memmove()` as well? -- Best regards, LH_Mouse
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
