在 2019/8/27 5:26, Christian Franke 写道: >> I have a couple of questions: >> >> 0) What was the purpose of the suppression of `-Wformat-nonliteral`? It >> seemed not added in every `v?sn?printf` function. > > The new inline sn?printf() functions delegate the call to (non-v) > *_sn?printf() functions. This is not the case in the existing code. > The pragmas are not really necessary as warnings are normally suppressed > for system includes. I added these because there are already 'ignored > "-Wshadow"' in this file.
Yeah I was asking that why those paradigms weren't added for `v*printf()` functions, because the delegation exist there as well. > > >> 1) As for 'string.h', there is already an `extern "C"` block, so is it >> necessary to declare a new one? Everything could have been in that >> one which saves some lines. > > Was needed because the sec_api/string_s.h was included in the middle and > I didn't want nested extern "C" blocks. No longer needed now. > > >> 2) Would you please add a wrapper for `memmove()` as well? > > Of course, plus mempcpy(). New patch attached. > > > `mempcpy()` is a GNU extension so please wrap it in an `#ifdef _GNU_SOURCE ... #endif` block. Also be advised that those `__builtin___*_chk()` things are only available since GCC 4.9. Your very first hunk checks for GCC 4.3 which is inconsistent. For maximum compatibility I suggest you get rid of those builtin things, declare those functions w/o the `__builtin_` prefix at the beginning of the file, and rewrite calls to them. -- Best regards, LH_Mouse
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
