在 2022-02-20 04:20, Martin Storsjö 写道:
On Sat, 19 Feb 2022, Pali Rohár wrote:

When assigning function pointer to variable, both function and variable
should have same signature. Fix it.
---

The patch looks ok to me, but I presume this is only a pedantic fix with no noticeable effect other than that - because if no calling convention is specified, __cdecl is the default?



I think we should always add `__cdecl` explicitly. MSVC has `/Gd`, `/Gr`, `/Gv`, `/Gz` which specify default calling conventions if none is given. GCC also has `-mrtd` [1] which sets the default one to `__stdcall` but I haven't seen many people use it so far.


[1] https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html



--
Best regards,
LIU Hao

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to