On Sun, 20 Feb 2022, LIU Hao wrote:
在 2022-02-20 04:20, Martin Storsjö 写道:
On Sat, 19 Feb 2022, Pali Rohár wrote:
When assigning function pointer to variable, both function and variable
should have same signature. Fix it.
---
The patch looks ok to me, but I presume this is only a pedantic fix with no
noticeable effect other than that - because if no calling convention is
specified, __cdecl is the default?
I think we should always add `__cdecl` explicitly. MSVC has `/Gd`, `/Gr`,
`/Gv`, `/Gz` which specify default calling conventions if none is given. GCC
also has `-mrtd` [1] which sets the default one to `__stdcall` but I haven't
seen many people use it so far.
Oh, thanks, that's a good point. Indeed, this patch is clearly fine, thus
pushed.
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
